c2c-oerpscenario team mailing list archive

["Olivier Dony \(OpenERP\)" <716710@xxxxxxxxxxxxxxxxxx>]

Hello Serge,

Thank you for reporting this bug quickly, analyzing it and even
proposing a patch!

This has been fixed in server trunk at revision 3355
odo@xxxxxxxxxxx-20110214102914-98gdvyx5y4v2kysx.

However I don't understand why you are saying that it caused the server to not support multiple paths anymore. As far as I can see this would just make the expansion of variables in addons path not work for all paths in multiple addons, right?
And since this is a new feature, the bug is just about the new feature being only partially working, isn't it?
Could you confirm that the full scope of the bug is now fixed for you after revision 3355 (just to be sure)? Thanks!

By the way, I think your patch only considered the last addons path,
because it overwrites the config value completely inside the "for loop",
so only the last one will be saved. You may have to double-check your
configuration after updating your server to the latest code.

PS: we do have automated test suites, including trunk branches, but as I
was saying, this is a new minor feature about expanding variables in
path, so it was not currently included in the existing test suites. If
you are interested, you can see the status of the tests in real-time at
http://test.openobject.com/

** Changed in: openobject-server
   Importance: Medium => Low

** Changed in: openobject-server
       Status: Confirmed => Fix Released

** Changed in: openobject-server
    Milestone: None => 6.1

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/716710

Title:
  [TRUNK 3353] dont more support multiple addons path

Status in OpenERP Server:
  Fix Released

Bug description:
  config.py

  if not self.options['addons_path'] or self.options['addons_path']=='None':
              self.options['addons_path'] = os.path.join(self.options['root_path'], 'addons')
          else:
              self.options['addons_path'] = os.path.abspath(os.path.expanduser(os.path.expandvars(self.options['addons_path'])))

  The Else dont support multipath (supporting before, and still support
  after my correction)

  Correction

   if not self.options['addons_path'] or self.options['addons_path']=='None':
              self.options['addons_path'] = os.path.join(self.options['root_path'], 'addons')
          else:
              o = self.options['addons_path']
              self.options['addons_path'] = ''
              for x in o.split(','):
                  self.options['addons_path'] = ','.join([self.options['addons_path'], os.path.abspath(os.path.expanduser(os.path.expandvars(x)))])

  So is not the better way, but atm i dont care i need that work.

  ps : i know this is a trunk, but before commit branch on trunk no test
  done to ensure all functionality follow ?