c2c-oerpscenario team mailing list archive

[xrg <xrg@xxxxxxxxx>]

On Thursday 24 February 2011, you wrote:
> Public bug reported:
> 
> OpenERP v6:
> 
> class GettextAlias in tools/translate.py requires a valid context
> available where _() was called. In some cases the context variable does
> not exsits or is not properly initialized. The attached patch provides a
> workarround by searching current user's language in order to find to
> which language it should translate.
> 

I have 2 objections to that: 
1. Speed. We want to avoid adding overhead to functions. The gettext one must 
remain as light as possible (it is sometimes over-used, more than 
appropriate).

2. Explicit/Implicit option to translate. In some cases, we explicitly don't 
want to have a translation. So far, we have been doing that by not specifying 
a 'lang' in the context. 1st example is the loading of a database and 
'internal' operations. 2nd example is in server/bin/osv/orm.py:4052 where we 
*must* avoid translation. 

Please think twice before breaking this logic.

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/724057

Title:
  translation needs context but it doesn't always exist

Status in OpenERP Server:
  Confirmed

Bug description:
  OpenERP v6:

  class GettextAlias in tools/translate.py requires a valid context
  available where _() was called. In some cases the context variable
  does not exsits or is not properly initialized. The attached patch
  provides a workarround by searching current user's language in order
  to find to which language it should translate.

  The patch is based on a Jay Vora patch provided in a v5 bug report:
  https://bugs.launchpad.net/openobject-addons/+bug/432504