c2c-oerpscenario team mailing list archive

[Raphaël Valyi - http://www.akretion.com <740353@xxxxxxxxxxxxxxxxxx>]

Hello,

sorry, but just like for many other fixes, I don't see the fix in the 6.0
branch. Is that really merged in the 6.0 branch or what?
If not, why don't use use the "fix committed" status for this bug and all
the others to explicit that it's not merged yet?
Are this bug-fixes meant for merge at all or are you building some secret
time-bomb for v6.0.2 or 6.1 where all will be merged to days before with
nobody testing the integration of the bug fix?
trunk if for new features and 6.0 is for bugfix maintenance, is that right?
Else the 6.0 branch would just not make any sense...
Could you please clarify or is that just a mistake with the status of a few
bugs?

Thanks.

On Fri, Mar 25, 2011 at 12:41 PM, qdp (OpenERP)
<qdp-launchpad@xxxxxxxxxxx>wrote:

> ** Changed in: openobject-addons
>       Status: Fix Committed => Fix Released
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/740353
>
> Title:
>  [account] slow invoice cancel because validate for every line; patch
>  included
>
> Status in OpenERP Modules (addons):
>   Fix Released
>
> Bug description:
>  Try to create a large invoice with like 100 lines and validate it
>  (it's slow but that's for an other one).
>
>  Now let's cancel it.
>  It's kind of slow like hell right?
>
>  In production with customer, it takes like 15 minutes to cancel... Not
>  very user friendly...
>
>  Now let's analyse why.
>  Let's put some print statement in the account_move#validate method.
>
>  You'll see that instead of passing here once per invoice, we are
>  passing here once per invoice line, after we remove every single move
>  line. This is stupid, we can do it only once after removing the lines.
>
>  This issue is that the generic unlink method from account_move_lines is
> not smart enough to take in consideration the case where all move lines
> belong to the same account move. But this is very common, especially in our
> common cancel invoice use case!
>  Given how slow the account_move#validate slow it, we should always try to
> factor the move ids together before calling this validate method, otherwise
> we just do the same slow thing over and over like 100 times in our test
> case.
>
>  The included patch just do that. Thank you to apply it, OpenERP users will
> thank you a lot.
>  Before our patch: 50 lines invoices would take 15 minutes to cancel; it
> now takes only 10 seconds. Call it an improvement ;-)
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/openobject-addons/+bug/740353/+subscribe
>

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/740353

Title:
  [account] slow invoice cancel because validate for every line; patch
  included

Status in OpenERP Modules (addons):
  Fix Released

Bug description:
  Try to create a large invoice with like 100 lines and validate it
  (it's slow but that's for an other one).

  Now let's cancel it.
  It's kind of slow like hell right?

  In production with customer, it takes like 15 minutes to cancel... Not
  very user friendly...

  Now let's analyse why.
  Let's put some print statement in the account_move#validate method.

  You'll see that instead of passing here once per invoice, we are
  passing here once per invoice line, after we remove every single move
  line. This is stupid, we can do it only once after removing the lines.

  This issue is that the generic unlink method from account_move_lines is not smart enough to take in consideration the case where all move lines belong to the same account move. But this is very common, especially in our common cancel invoice use case!
  Given how slow the account_move#validate slow it, we should always try to factor the move ids together before calling this validate method, otherwise we just do the same slow thing over and over like 100 times in our test case.

  The included patch just do that. Thank you to apply it, OpenERP users will thank you a lot.
  Before our patch: 50 lines invoices would take 15 minutes to cancel; it now takes only 10 seconds. Call it an improvement ;-)