c2c-oerpscenario team mailing list archive

[xrg <xrg@xxxxxxxxx>]

On Monday 04 April 2011, you wrote:
> Public bug reported:
> 
> Hello, the base_vat_mx validation there is bug.
> 
> I have a fix
> I attach the patch
> 

Hello,
can we have a little bit more explanation of that patch, please?

What patterns is it supposed to recognize? Which ones will it eventually 
discard as invalid?

I see that you have a "filter" step in the validation process. So, doesn't that 
allow random patterns to pass as valid (because it filters out unknown chars)? 
Is that desirable?

I prefer an approach like: the official format of a mexican VAT number is "...", 
alternative formats may be like "...." , we discard anything else[1].

[1] a good criterion would be "what formats would the authorities in Mexico 
expect to see in a legal form? Which ones will they tell you to correct?"

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/749958

Title:
  [trunk] [base_vat] [base_vat_mx]: Wrong validation

Status in OpenERP Modules (addons):
  New

Bug description:
  Hello, the base_vat_mx validation there is bug.

  I have a fix
  I attach the patch