c2c-oerpscenario team mailing list archive

["Naresh\(OpenERP\)" <nch@xxxxxxxxxxx>]

Hello Phong Nguyen-Thanh,

I think the value for timezone that you are setting is wrong. if you
read the help for the options on the server it clearly explains that

  -t TIMEZONE, --timezone=TIMEZONE
                        specify reference timezone for the server (e.g.
                        Europe/Brussels

timezone = False means there is no timezone.

Secondly the most improtant is that the user should be warned instead of
traceback The framework should restrict this.

you have patched the clien but there is no need for the client to be
patched. You have converted the boolean values to string to support the
upper function of string. No, rather a better way is to restrict the
case from the server  itself. the server method "timezone_get" should
only return the valid timezone value else False.


Correct me If I am missing something !


Thanks



** Project changed: openobject-client => openobject-server

** Changed in: openobject-server
     Assignee: OpenERP sa GTK client R&D (openerp-dev-gtk) => OpenERP's Framework R&D (openerp-dev-framework)

** Changed in: openobject-server
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/675826

Title:
  AttributeError: 'bool' object has no attribute 'upper'

Status in OpenERP Server:
  Confirmed

Bug description:
  openerp-client.py crashes after login

  ~/Documents/Projects/openerp-trunk/client$ bin/openerp-client.py --sync
  Traceback (most recent call last):
    File "bin/openerp-client.py", line 133, in <module>
      win.sig_login()
    File "/home/phongnt/Documents/Projects/openerp-trunk/client/bin/modules/gui/main.py", line 1020, in sig_login
      log_response = rpc.session.login(*res)
    File "/home/phongnt/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 253, in login
      self.context_reload()~/Documents/Projects/openerp-trunk/client$ bin/openerp-client.py --sync
  Traceback (most recent call last):
    File "bin/openerp-client.py", line 133, in <module>
      win.sig_login()
    File "/Documents/Projects/openerp-trunk/client/bin/modules/gui/main.py", line 1020, in sig_login
      log_response = rpc.session.login(*res)
    File "/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 253, in login
      self.context_reload()
    File "/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 331, in context_reload
      pytz.timezone(self.timezone)
    File "/usr/lib/python2.6/dist-packages/pytz/__init__.py", line 138, in timezone
      if zone.upper() == 'UTC':
  AttributeError: 'bool' object has no attribute 'upper'

    File "/home/phongnt/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 331, in context_reload
      pytz.timezone(self.timezone)
    File "/usr/lib/python2.6/dist-packages/pytz/__init__.py", line 138, in timezone
      if zone.upper() == 'UTC':
  AttributeError: 'bool' object has no attribute 'upper'

  Information related to repository and revision

  ~/Documents/Projects/openerp-trunk/client$ bzr info
  Standalone tree (format: 2a)
  Location:
    branch root: .

  Related branches:
    parent branch: bzr+ssh://bazaar.launchpad.net/~openerp/openobject-client/trunk/

  ~/Documents/Projects/openerp-trunk/client$ bzr log -l 1 -v
  ------------------------------------------------------------
  revno: 1684
  committer: nch@xxxxxxxxxxx
  branch nick: trunk
  timestamp: Fri 2010-11-12 17:04:29 +0530
  message:
    [FIX]:IndexError: list index out of range when configuration wizards fails and user presses skip button
  modified:
    bin/widget/model/field.py