c2c-oerpscenario team mailing list archive

[Phong Nguyen-Thanh <675826@xxxxxxxxxxxxxxxxxx>]

I haven't got time to dig into the server code, but I think the server
return False would make sense to me, as it signifies that the either
timezone is wrongly set or something else that it couldn't fix. In that
case, what value do you expect the timezone should be set to? Default EU
or US timezone? It will certainly mix up all the local time. I would
rather leave the timezone as empty. Having said that, patching for
better server code is welcome.

On the client side, I think it's bad that a wrongly config timezone is
blocking/crashing the client. I recall an old saying in programming "be
literal in accepting what you receive, and be strict what you provide".
Thus, maybe the client should be patched, regardless of what have been
done in the server.

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/675826

Title:
  AttributeError: 'bool' object has no attribute 'upper'

Status in OpenERP Server:
  Confirmed

Bug description:
  openerp-client.py crashes after login

  ~/Documents/Projects/openerp-trunk/client$ bin/openerp-client.py --sync
  Traceback (most recent call last):
    File "bin/openerp-client.py", line 133, in <module>
      win.sig_login()
    File "/home/phongnt/Documents/Projects/openerp-trunk/client/bin/modules/gui/main.py", line 1020, in sig_login
      log_response = rpc.session.login(*res)
    File "/home/phongnt/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 253, in login
      self.context_reload()~/Documents/Projects/openerp-trunk/client$ bin/openerp-client.py --sync
  Traceback (most recent call last):
    File "bin/openerp-client.py", line 133, in <module>
      win.sig_login()
    File "/Documents/Projects/openerp-trunk/client/bin/modules/gui/main.py", line 1020, in sig_login
      log_response = rpc.session.login(*res)
    File "/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 253, in login
      self.context_reload()
    File "/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 331, in context_reload
      pytz.timezone(self.timezone)
    File "/usr/lib/python2.6/dist-packages/pytz/__init__.py", line 138, in timezone
      if zone.upper() == 'UTC':
  AttributeError: 'bool' object has no attribute 'upper'

    File "/home/phongnt/Documents/Projects/openerp-trunk/client/bin/rpc.py", line 331, in context_reload
      pytz.timezone(self.timezone)
    File "/usr/lib/python2.6/dist-packages/pytz/__init__.py", line 138, in timezone
      if zone.upper() == 'UTC':
  AttributeError: 'bool' object has no attribute 'upper'

  Information related to repository and revision

  ~/Documents/Projects/openerp-trunk/client$ bzr info
  Standalone tree (format: 2a)
  Location:
    branch root: .

  Related branches:
    parent branch: bzr+ssh://bazaar.launchpad.net/~openerp/openobject-client/trunk/

  ~/Documents/Projects/openerp-trunk/client$ bzr log -l 1 -v
  ------------------------------------------------------------
  revno: 1684
  committer: nch@xxxxxxxxxxx
  branch nick: trunk
  timestamp: Fri 2010-11-12 17:04:29 +0530
  message:
    [FIX]:IndexError: list index out of range when configuration wizards fails and user presses skip button
  modified:
    bin/widget/model/field.py