c2c-oerpscenario team mailing list archive

["Mustufa Rangwala \(Open ERP\)" <mra@xxxxxxxxxxx>]

Hello,

Yes we are getting period_id in vals and we should use it.
so defining period_id at begining of the method seems ok but at the time of condition:

journal = journal_obj.browse(cr, uid, journal_id, context=context)
if journal.allow_date and period_id:

we should use period_id from vals.
can you please check

thanks,
mra


** Changed in: openobject-addons
       Status: Fix Committed => Confirmed

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/783994

Title:
  account_move_line: uninitialized period_id

Status in OpenERP Modules (addons):
  Confirmed

Bug description:
  Hi,

  We obtained the following stack trace while creating a journal entry.
  Although I'm not sure of the root cause, there is indeed a code path
  where period_id may be uninitialized. I attach a proposed patch.

  Best regards,

  -sbi

  Environment Information : 
  System : Windows-32bit-SP2
  OS Name : nt
  Operating System Release : 
  Operating System Version : 32bit
  Operating System Architecture : 32bit
  Operating System Locale : fr_BE.cp1252
  Python Version : 2.5.2
  OpenERP-Client Version : 6.0.2
  Last revision No. & ID :Bazaar Package not Found !Traceback (most recent call last):
    File "/usr/local/bin/openerp6/lib/python2.6/site-packages/openerp-server/netsvc.py", line 489, in dispatch
      result = ExportService.getService(service_name).dispatch(method, auth, params)
    File "/usr/local/bin/openerp6/lib/python2.6/site-packages/openerp-server/service/web_services.py", line 599, in dispatch
      res = fn(db, uid, *params)
    File "/usr/local/bin/openerp6/lib/python2.6/site-packages/openerp-server/osv/osv.py", line 122, in wrapper
      return f(self, dbname, *args, **kwargs)
    File "/usr/local/bin/openerp6/lib/python2.6/site-packages/openerp-server/osv/osv.py", line 176, in execute
      res = self.execute_cr(cr, uid, obj, method, *args, **kw)
    File "/usr/local/bin/openerp6/lib/python2.6/site-packages/openerp-server/osv/osv.py", line 167, in execute_cr
      return getattr(object, method)(cr, uid, *args, **kw)
    File "/usr/local/src/openerp6/addons-fixes/account/account_move_line.py", line 1221, in create
      self._check_date(cr, uid, vals, context, check)
    File "/usr/local/src/openerp6/addons-fixes/account/account_move_line.py", line 1123, in _check_date
      if journal.allow_date and period_id:
  UnboundLocalError: local variable 'period_id' referenced before assignment