c2c-oerpscenario team mailing list archive

["Jay Vora \(OpenERP\)" <jvo@xxxxxxxxxxx>]

Rifakat,

Thanks for the merge proposal.

You've got it working, but the problem ain't going away.

+1 for the adding the active button, But  I don't think we should add in
6.0.

More discussion is needed to make the consistent behavior.

Honestly, adding domain active=True is a real insult of search().

So, please don't choose that way.

For now,I'm concerned about
hr_holidays/report/holidays_summary_report.py.

You better replace the query by your change, but not the active=true
part.

All,

The real problem resides in ORM where it ignores the active_test. Th
reason being is only the condition of 'active' in self._columns.

Remember, 'active' field is no more a field of hr_employee, its an
_inherited..

This problem could appear for all such victims.

So, the solution stays as replacing the line 3853 by if 'active' in
(self._columns.keys() + self._inherit_fields.keys()) and (active_test
and context.get('active_test', True)):.

This is an alarming situation for all those codes where only
self._columns have been taken into consideration, not
self._inherits/_inherit_fields.

Thanks (also for reading).

** Changed in: openobject-addons
    Milestone: None => 6.0.4

** Also affects: openobject-server
   Importance: Undecided
       Status: New

** Changed in: openobject-server
       Status: New => Confirmed

** Changed in: openobject-server
   Importance: Undecided => Low

** Changed in: openobject-server
     Assignee: (unassigned) => OpenERP Publisher's Warranty Team (openerp-opw)

** Changed in: openobject-server
    Milestone: None => 6.0.4

-- 
You received this bug notification because you are a member of C2C
OERPScenario, which is subscribed to the OpenERP Project Group.
https://bugs.launchpad.net/bugs/832569

Title:
  [6.0] hr_holidays, holidays report per department shows Inactive
  employees

Status in OpenERP Modules (addons):
  Confirmed
Status in OpenERP Server:
  Confirmed

Bug description:
  Hello,

  When showing employees' holidays per departments report, unactives
  employees are shown.

  A psql request isn't checking the employee status in:
  http://bazaar.launchpad.net/~openerp/openobject-addons/6.0/view/head:/hr_holidays/report/holidays_summary_report.py

  A proposed patch that corrects the request to get only active
  employees is added.

  Best Regards,
  Yannick

To manage notifications about this bug go to:
https://bugs.launchpad.net/openobject-addons/+bug/832569/+subscriptions