← Back to team overview

cairo-dock-team team mailing list archive

Re: [Bug 523447] Re: MusicPlayer applet crashes on tracks with russians symbols

 

we are supposed to receive and return UTF-8 everywhere in the dock.
it's valid to do while(*++s) since a nul byte is not permitted in any UTF-8
character (except the NULL one).
I also think it's a memory corruption around this function in one of the
strings, but I can't find where exactly :-/

2010/4/23 Tofe <chris.chapuis@xxxxxxxxx>

> It may be caused by a bad support of some unicode string. Looking at the
> error makes me think there's a sort of buffer overflow there:
>
> applet-amazon.c:_url_encode:220
>
> When I look at this location, I see this:
>
>    }while(*++s); // avance d'un cran dans la chaine. Si on est pas à la
> fin, on continue...
>    s = str;
>    /// la ligne suivane peut planter ...
>    cd_debug ("allocation of %d bytes...\n", lenght + 1);
>    t = g_new (gchar, lenght + 1); // Allocation à la bonne taille
>
> For example, is "while(*++s)" valid for a unicode string?
>
> Tofe
>
> On Fri, Apr 23, 2010 at 3:22 PM, Matthieu Baerts <matttbe@xxxxxxxxx>
> wrote:
>
> > It's hard to find the cause :-/ . Is it still present in the v.2.1.3-9 ?
> >
> > --
> > MusicPlayer applet crashes on tracks with russians symbols
> > https://bugs.launchpad.net/bugs/523447
> > You received this bug notification because you are a member of Cairo-
> > Dock Team, which is the registrant for Cairo-Dock Plug-ins.
> >
> > Status in Cairo-Dock : Plug-ins: New
> >
> > Bug description:
> > When just beginning to play a song where the title, artist or album,
> > written by Russian symbols, Cairo-Dock starts turned off, and then be
> > switched etc.
> >
> > Example:
> > Title - Актриса-Весна
> > Artist - ДДТ
> > Album - Актриса-Весна
> >
> > after some restarts I see
> > http://img269.imageshack.us/img269/8481/94860681.png in htop
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> <https://launchpad.net/%7Ecairo-dock-team>
> > Post to     : cairo-dock-team@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> <https://launchpad.net/%7Ecairo-dock-team>
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> --
> MusicPlayer applet crashes on tracks with russians symbols
> https://bugs.launchpad.net/bugs/523447
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is the registrant for Cairo-Dock Plug-ins.
>
> Status in Cairo-Dock : Plug-ins: New
>
> Bug description:
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
>
> after some restarts I see
> http://img269.imageshack.us/img269/8481/94860681.png in htop
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to     : cairo-dock-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help   : https://help.launchpad.net/ListHelp
>

-- 
MusicPlayer applet crashes on tracks with russians symbols
https://bugs.launchpad.net/bugs/523447
You received this bug notification because you are a member of Cairo-
Dock Team, which is the registrant for Cairo-Dock Plug-ins.

Status in Cairo-Dock : Plug-ins: New

Bug description:
When just beginning to play a song where the title, artist or album, written by Russian symbols, Cairo-Dock starts turned off, and then be switched etc.

Example:
Title - Актриса-Весна
Artist - ДДТ
Album - Актриса-Весна

after some restarts I see http://img269.imageshack.us/img269/8481/94860681.png in htop






References