← Back to team overview

cairo-dock-team team mailing list archive

[Bug 576647] Re: Please update Cairo-Dock with the following patches

 

@ Martin: I've already tested it by compiling the source code with the patch and all was fine.
And now I've just installed this package from "Proposed" repositories on another computer with a fresh install and all these bugs are fixed! (but it should be easier if this package is copy to Universe repository ;) )

Thank you

-- 
Please update Cairo-Dock with the following patches
https://bugs.launchpad.net/bugs/576647
You received this bug notification because you are a member of Cairo-
Dock Team, which is subscribed to cairo-dock-plug-ins in ubuntu.

Status in “cairo-dock-plug-ins” package in Ubuntu: Fix Released
Status in “cairo-dock-plug-ins” source package in Lucid: Fix Committed
Status in “cairo-dock-plug-ins” source package in Maverick: Fix Released

Bug description:
Binary package hint: cairo-dock-plug-ins

We have found and corrected 4 critical bugs in the package Cairo-Dock-plug-ins.
Here is a short summary:

* LP: #575178 (MP: fixed a double-free on the "cover-dir" variable of the banshee backend)
TEST CASE : deactivate the musicPlayer applet -> it crashes

* LP: #523447 (MP: fixed a memory buffer overflow when getting the cover if the artist or album has chinese/russian characters)
TEST CASE : Activate the musicPlayer applet, configure it to Rythmbox, and play a song with russian characters. For a concrete example, you can just rename any song with the names given in the bug on LP.
-> the dock will crash (it may crash some time later, depending on where it wrote in the memory)

* CD Forum: Switcher : fixed a division by 0 in the case the number of desktop is null (can occur if the dock is launched before the WM)
TEST CASE : this one is hard to test, since it requires the dock to be launched before the WM; This si quite rare, but many users have encountered it.
-> Adding a delay on startup prevents the crash, which proves that the problem is linked to the startup order of the dock and the WM.

* CD Forum: Mail : allow the dock to isolate the applet if it crashes.
TEST CASE : in some case the applet may crash (it may be a bug in libetpan though, this is not yet clear)
The patch is here to allow the dock to isolate the applet and prevents the whole application from crashing.
The test case requires to make the applet crash, which is not obvious. Anyway, the patch doesn't fix anything, it just prevents the whole application to fall in case a problem occurs in Mail (which is already used in many other applets).

All these bugs are critical since they cause the application to crash, and they involve memory corruption or memory overflow.
The patches are basic and almost 1 line each time.

Thanks in advance!







Follow ups

References