cairo-dock-team team mailing list archive

[Fabounet <fabounet03@xxxxxxxxx>]

Thanks a lot for this clear patch !
I apply it immediately on my branch :-)

2010/12/7 Tsu Jan <686564@xxxxxxxxxxxxxxxxxx>

>
> ** Patch added: "cairo-dock-gio-vfs.c.diff"
>
> https://bugs.launchpad.net/bugs/686564/+attachment/1758453/+files/cairo-dock-gio-vfs.c.diff
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is subscribed to Cairo-Dock Plug-ins.
> https://bugs.launchpad.net/bugs/686564
>
> Title:
>  Trash not emptied with folders from other partitions
>
> Status in Cairo-Dock : Plug-ins:
>  New
>
> Bug description:
>  When a folder from a partition other than the home partition is put into
> the trash, the trash can't be emptied with middle-clicking on the dustbin
> applet. I get an error like this:
>
> ------------------
> vfs.c:cairo_dock_gio_vfs_empty_trash:1624) [0m
> gnome_integration : Error removing file: Directory not empty
> GError set over the top of a previous GError or uninitialized memory.
> This indicates a bug in someone's code. You must ensure an error is NULL
> before it's set.
> The overwriting error message was: Error removing file: No such file or
> directory
> ------------------
>
> The GError part can be fixed by using "g_file_delete (file, NULL, NULL)" in
> that section of the function "cairo_dock_gio_vfs_empty_trash", which is
> related to the deletion of info files.
>
> To fix "Error removing file: Directory not empty", in the same function, I
> added "G_FILE_ATTRIBUTE_STANDARD_TYPE" to "cAttributes" and set the
> following condition in a proper place:
>
> if (iFileType == G_FILE_TYPE_DIRECTORY)
>
> {
>
>        cairo_dock_gio_vfs_empty_dir (sFileUri->str);
>
> }
>
> I've attached a patch.
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to     : cairo-dock-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help   : https://help.launchpad.net/ListHelp
>

-- 
You received this bug notification because you are a member of Cairo-
Dock Team, which is subscribed to Cairo-Dock Plug-ins.
https://bugs.launchpad.net/bugs/686564

Title:
  Trash not emptied with folders from other partitions

Status in Cairo-Dock : Plug-ins:
  New

Bug description:
  When a folder from a partition other than the home partition is put into the trash, the trash can't be emptied with middle-clicking on the dustbin applet. I get an error like this:

------------------
vfs.c:cairo_dock_gio_vfs_empty_trash:1624) [0m 
gnome_integration : Error removing file: Directory not empty
GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: Error removing file: No such file or directory
------------------

The GError part can be fixed by using "g_file_delete (file, NULL, NULL)" in that section of the function "cairo_dock_gio_vfs_empty_trash", which is related to the deletion of info files.

To fix "Error removing file: Directory not empty", in the same function, I added "G_FILE_ATTRIBUTE_STANDARD_TYPE" to "cAttributes" and set the following condition in a proper place:

if (iFileType == G_FILE_TYPE_DIRECTORY)

{

	cairo_dock_gio_vfs_empty_dir (sFileUri->str);

}

I've attached a patch.