cairo-dock-team team mailing list archive

[Matthieu Baerts <matttbe@xxxxxxxxx>]

Review: Needs Fixing

Hello and thank you for this new applet :)

I dropped a link into the applet but your applet has crashed. I'm sorry, I don't have time to help debugging it but I can give you output messages produced in the terminal just before the crash:
    (YoutubeDl:13113): libnotify-WARNING **: you must call notify_init() before showing
    **
    libnotify:ERROR:notification.c:568:notify_notification_show: code should not be reached

Do you use the latest version of CDApplet (from Cairo-Dock 3.0.0)?
I see that you're using CairoDockPlugin.py from Diskfree. It should work but it's maybe not a good idea because this old applet is still not using CDApplet (it's better to only use it in order to use the right DBus address, the right directories, etc.
Don't hesitate to have a look to other applets (demo, Screensaver_inhibitor, Gmail, Quote, Twitter, etc.) ;)

Also, a tiny detail: It's not necessary to add the full content of the license, you can just say that the licence is available there: /usr/share/common-licenses/GPL-3 (or: https://www.gnu.org/licenses/gpl.html)
-- 
https://code.launchpad.net/~mycompostpile/cairo-dock-plug-ins-extras/YoutubeDl/+merge/105749
Your team Cairo-Dock Team is subscribed to branch lp:cairo-dock-plug-ins-extras.