← Back to team overview

cairo-dock-team team mailing list archive

[Merge] lp:~eduardo-mucelli/cairo-dock-plug-ins-extras/Twitter into lp:cairo-dock-plug-ins-extras

 

Eduardo Mucelli Rezende Oliveira has proposed merging lp:~eduardo-mucelli/cairo-dock-plug-ins-extras/Twitter into lp:cairo-dock-plug-ins-extras.

Requested reviews:
  Cairo-Dock Team (cairo-dock-team)

For more details, see:
https://code.launchpad.net/~eduardo-mucelli/cairo-dock-plug-ins-extras/Twitter/+merge/106485

Twitter: Properly fixing the alert mark that was there, even after Twitter account was added. Not allowing the tweet dialog to appear if none of the networks is available.
-- 
https://code.launchpad.net/~eduardo-mucelli/cairo-dock-plug-ins-extras/Twitter/+merge/106485
Your team Cairo-Dock Team is requested to review the proposed merge of lp:~eduardo-mucelli/cairo-dock-plug-ins-extras/Twitter into lp:cairo-dock-plug-ins-extras.
=== modified file 'Twitter/Twitter'
--- Twitter/Twitter	2012-05-19 00:12:14 +0000
+++ Twitter/Twitter	2012-05-19 00:42:25 +0000
@@ -407,8 +407,12 @@
     }
     return identica_menu
     
+  def any_active_network(self):
+    return self.twitter.api or self.identica.api
+        
   def set_visual_for_active_networks(self):
     if self.twitter.api:
+      self.icon.SetIcon(os.path.abspath("./icon"))                                  # overwrite the alert mark "!!!"
       if self.identica.api:
         self.icon.SetLabel("Twitter and Identi.ca")
         self.icon.SetIcon(os.path.abspath("./data/twitter_and_identica.png"))
@@ -498,7 +502,8 @@
     elif not self.message_stream.empty():
       self.show_new_direct_messages()
     else:
-      self.ask_for_tweet()
+      if self.any_active_network():
+        self.ask_for_tweet()
 
   def on_middle_click(self):
     self.show_home_timeline()


Follow ups