cairo-dock-team team mailing list archive

[Matthieu Baerts <matttbe@xxxxxxxxx>]

Review: Approve

Thank you for this new version ;)
(I just fix a typo in the .conf file => use bzr pull to be sync with the trunk)

About the video folder (and the directory for the URL list), it can be interesting to check if this dir exists and if not, if it can be created (if not, it should at least display an error message).

e.g:

=== modified file 'YoutubeDl/myYoutubeDownloader.py'
--- YoutubeDl/myYoutubeDownloader.py	2012-06-01 22:55:12 +0000
+++ YoutubeDl/myYoutubeDownloader.py	2012-06-02 22:02:22 +0000
@@ -89,6 +89,10 @@
                     directoryName=directoryName.rstrip()
                     videos_directory = os.path.abspath(directoryName)
 
+                if os.path.isfile(videos_directory):
+                    print "Problem..." # show a dialogue? and use the default dir?
+                if not os.path.isdir(videos_directory):
+                    os.makedirs(videos_directory) # should raise an error exception if it cannot be created (e.g. if the user has no right to create this dir)
                 if not (videos_directory == os.path.abspath('.')):
                     os.chdir(videos_directory)
                 if doDebug:


PS: about the list with all URL, you can also directly use pyGTK (GMail and Twitter applets use pyGTK to have a list and GTG use it to display a kind of 'post-it'.

-- 
https://code.launchpad.net/~mycompostpile/cairo-dock-plug-ins-extras/YoutubeDl/+merge/108440
Your team Cairo-Dock Team is subscribed to branch lp:cairo-dock-plug-ins-extras.