← Back to team overview

cairo-dock-team team mailing list archive

[Bug 1050526] Re: no-return-in-nonvoid-function

 

Hello and thank you for this bug report and this patch!

I just commited these changes on BZR (rev 2547¹).
I only changed that: In file dustbin/src/applet-notifications.c "static gboolean _display_result (CDSharedMemory *pSharedMemory)" needs "return FALSE;" at the end because it's the end of the task (but the result should be the same).


*@ fabounet*: can you check that it's correct?

[1] https://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-plug-ins
/plug-ins/revision/2547

** Changed in: cairo-dock-plug-ins
       Status: New => Fix Committed

** Changed in: cairo-dock-plug-ins
     Assignee: (unassigned) => Fabounet (fabounet03)

** Changed in: cairo-dock-plug-ins
    Milestone: None => 3.1.0

** Changed in: cairo-dock-plug-ins
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Cairo-
Dock Team, which is subscribed to Cairo-Dock Plug-ins.
https://bugs.launchpad.net/bugs/1050526

Title:
  no-return-in-nonvoid-function

Status in Cairo-Dock: Plug-ins:
  Fix Committed

Bug description:
  1) In file Dbus/src/interface-main-methods.c "static gboolean _on_icon_deleted (GList *ic, Icon *pIcon)" needs "return CAIRO_DOCK_INTERCEPT_NOTIFICATION;" at the end.
  2) In file alsaMixer/src/applet-init.c.diff "static gboolean _cd_mixer_on_enter (GtkWidget* pWidget, GdkEventCrossing* pEvent, gpointer data)" and "gboolean _cd_mixer_on_leave (GtkWidget* pWidget, GdkEventCrossing* pEvent, gpointer data)" needs "return CAIRO_DOCK_INTERCEPT_NOTIFICATION;" at the end.
  3) In file dock-rendering/src/rendering-parabole.c "static double cd_rendering_project_cursor_on_curve (double x0, double y0, double lambda, double alpha, double *fXOnCurve, double *fYOnCurve)" return type should be changed to void.
  4) In file dustbin/src/applet-notifications.c "static gboolean _display_result (CDSharedMemory *pSharedMemory)" needs "return TRUE;" at the end.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cairo-dock-plug-ins/+bug/1050526/+subscriptions


Follow ups

References