← Back to team overview

cairo-dock-team team mailing list archive

Re: [Merge] lp:~eduardo-mucelli/cairo-dock-plug-ins-extras/WebSearch into lp:cairo-dock-plug-ins-extras

 

Hi,

Thank you for these new modifications! :)

I just want to quickly give you some tips/advices:
 * About the commit message, it's maybe better to start it with the name of the applet as you did here ;) [1]
 * No need to bump the version number of your applet if you don't change the .conf file (but you can do that if you want to have a detailed changelog for each modification but you can also have a version number and a lot of changes ;) )
 * list.conf: we regularly forgot it :) but it's interesting to directly modify the list.conf file (the 'last modif' key of your applet)

It's just a few details but I think it's better to inform you about that ;)

Have a nice day,

Matt

PS: I just push a new commit, don't forget to 'pull' ;)

[1] For more advices about the commit message, please have a look there: http://www.glx-dock.org/ww_page.php?p=Help%20us%20with%20BZR&lang=en#18-About%20the%20commit%20message


-- 
https://code.launchpad.net/~eduardo-mucelli/cairo-dock-plug-ins-extras/WebSearch/+merge/169532
Your team Cairo-Dock Third-Party is subscribed to branch lp:cairo-dock-plug-ins-extras.


References