canonical-hw-cert team mailing list archive

[Kevin Yeh <mp+426918@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

please see my inline comment.

Diff comments:

> diff --git a/jobs/infrastructure/build-checkbox/snap-build-checkbox-katy.yaml b/jobs/infrastructure/build-checkbox/snap-build-checkbox-katy.yaml
> new file mode 100644
> index 0000000..4fef05e
> --- /dev/null
> +++ b/jobs/infrastructure/build-checkbox/snap-build-checkbox-katy.yaml
> @@ -0,0 +1,13 @@
> +- project:
> +    name: checkbox-katy
> +    description: |
> +      This job will build and publish checkbox-katy
> +    source-url: git+ssh://$GITUSER@xxxxxxxxxxxxxxxxx/~katy-team/katy/+git/checkbox-katy
> +    source-branch: main
> +    release-targets: 'latest/edge'
> +    lxd_template: ubuntu:focal
> +    channel: '6.x/stable'
> +    check-branches: ''

I think you should add checkbox-{project}-provider here, if you want this job is triggered when provider is changed.

> +    jobs:
> +      - 'snap-build-{name}-local-trigger'
> +      - 'snap-build-{name}-local'


-- 
https://code.launchpad.net/~stanley31/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/426918
Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master.