canonical-hw-cert team mailing list archive

[Paul Larson <mp+442768@xxxxxxxxxxxxxxxxxx>]

Paul Larson has proposed merging ~pwlars/hwcert-jenkins-jobs:urllib3-2.0-breaks-the-world into hwcert-jenkins-jobs:master.

Requested reviews:
  hwcert-jenkins (hwcert-jenkins)

For more details, see:
https://code.launchpad.net/~pwlars/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/442768

I tested this locally. You won't see this fail with the test runs, because it doesn't get hit until it actually tries to connect to jenkins for real and update the jobs. There's a bug about it already, but for now, since urllib3 latest releases seem to be breaking a LOT of things, the recommended approach seems to be to keep it from updating past 2.0.

https://bugs.launchpad.net/python-jenkins/+bug/2018567
-- 
Your team hwcert-jenkins is requested to review the proposed merge of ~pwlars/hwcert-jenkins-jobs:urllib3-2.0-breaks-the-world into hwcert-jenkins-jobs:master.

diff --git a/.pmr-merge-hook b/.pmr-merge-hook
index 1624605..25bd56c 100755
--- a/.pmr-merge-hook
+++ b/.pmr-merge-hook
@@ -5,6 +5,9 @@ set -e
 rm -rf jjbenv
 virtualenv -q -p python3 jjbenv
 . jjbenv/bin/activate
+# https://bugs.launchpad.net/python-jenkins/+bug/2018567
+pip install -qq "urllib3<2.0"
+# Template incompatibilities with newer jjb releases
 pip install -qq "jenkins-job-builder<5.0"
 
 jenkins-jobs --conf test.conf test production.yaml:jobs > /dev/null