canonical-hw-cert team mailing list archive

[Jonathan Cave <mp+429501@xxxxxxxxxxxxxxxxxx>]

Review: Needs Information

Thanks, being able to run testing with snaps is much needed.

Did just want to query the additional dependencies installed below

Diff comments:

> diff --git a/jobs/sru/run-sru.sh b/jobs/sru/run-sru.sh
> index 12bcd4b..fed0583 100644
> --- a/jobs/sru/run-sru.sh
> +++ b/jobs/sru/run-sru.sh
> @@ -155,31 +155,42 @@ cat > job.yaml <<EOF
>          _run sudo fuser -v /var/cache/debconf/config.dat
>          _run sudo apt-get -qq purge -y appstream
>  
> -        echo "Set up x86 basic packages, e.g. checkbox etc...."
> -        # Remove checkbox first if it's already there, and remove checkbox-dev ppa
> -        _run sudo apt-get -qq purge -y checkbox-ng
> -        _run sudo apt-get -qq purge -y python3-checkbox-ng
> -        _run sudo apt-get -qq purge -y python3-checkbox-support
> -        _run sudo apt-get -qq purge -y plainbox-provider-*
> -        _run sudo apt-get -qq purge -y checkbox-provider-*
> -        _run sudo add-apt-repository --remove -y ppa:checkbox-dev/ppa
> -
> -        _run "echo \"postfix postfix/mailname string \$(hostname)\" | sudo debconf-set-selections"
> -        _run "echo  \"postfix postfix/main_mailer_type string 'Internet Site'\" | sudo debconf-set-selections"
> -        _run sudo add-apt-repository {checkbox_ppa} -y
> -        _run sudo apt-get -qq update
> -        _run sudo /home/ubuntu/wait-resource.sh
> -        _run sudo fuser -v /var/lib/apt/lists/lock
> -        _run sudo fuser -v /var/lib/dpkg/lock
> -        _run sudo fuser -v /var/cache/debconf/config.dat
> -        _run sudo DEBIAN_FRONTEND={debian_frontend} apt-get -qq install -o Dpkg::Options::="--force-confdef" -y --force-yes checkbox-ng python3-checkbox-ng plainbox-provider-checkbox plainbox-provider-resource-generic plainbox-provider-sru fswebcam obexftp wmctrl iperf mesa-utils vim pastebinit fwts xorg-dev gir1.2-clutter-1.0
> +        if [ "{checkbox_snap}" == False ]; then
> +            echo "Set up x86 basic packages, e.g. checkbox etc...."
> +            # Remove checkbox first if it's already there, and remove checkbox-dev ppa
> +            _run sudo apt-get -qq purge -y checkbox-ng
> +            _run sudo apt-get -qq purge -y python3-checkbox-ng
> +            _run sudo apt-get -qq purge -y python3-checkbox-support
> +            _run sudo apt-get -qq purge -y plainbox-provider-*
> +            _run sudo apt-get -qq purge -y checkbox-provider-*
> +            _run sudo add-apt-repository --remove -y ppa:checkbox-dev/ppa
> +
> +            _run "echo \"postfix postfix/mailname string \$(hostname)\" | sudo debconf-set-selections"
> +            _run "echo  \"postfix postfix/main_mailer_type string 'Internet Site'\" | sudo debconf-set-selections"
> +            _run sudo add-apt-repository {checkbox_ppa} -y
> +            _run sudo apt-get -qq update
> +            _run sudo /home/ubuntu/wait-resource.sh
> +            _run sudo fuser -v /var/lib/apt/lists/lock
> +            _run sudo fuser -v /var/lib/dpkg/lock
> +            _run sudo fuser -v /var/cache/debconf/config.dat
> +            _run sudo DEBIAN_FRONTEND={debian_frontend} apt-get -qq install -o Dpkg::Options::="--force-confdef" -y --force-yes checkbox-ng python3-checkbox-ng plainbox-provider-checkbox plainbox-provider-resource-generic plainbox-provider-sru fswebcam obexftp wmctrl iperf mesa-utils vim pastebinit fwts xorg-dev gir1.2-clutter-1.0
>          
> -        # Phoronix Test Suite provider is only available for some releases
> -        if [[ {arch} = amd64 ]] && [[ {series} =~ ^(xenial|bionic)$ ]]; then
> -            _run sudo apt-get install -y checkbox-provider-phoronix libssl1.1
> -            echo "Preparing the PTS cache"
> -            _run mkdir /var/tmp/pts-cache
> -            _run "wget -qO- {cert-file-tel}/sru/phoronix_cache/x64/{series}/pts-cache.tar.gz |tar xz -C /var/tmp/pts-cache"
> +            # Phoronix Test Suite provider is only available for some releases
> +            if [[ {arch} = amd64 ]] && [[ {series} =~ ^(xenial|bionic)$ ]]; then
> +                _run sudo apt-get install -y checkbox-provider-phoronix libssl1.1
> +                echo "Preparing the PTS cache"
> +                _run mkdir /var/tmp/pts-cache
> +                _run "wget -qO- {cert-file-tel}/sru/phoronix_cache/x64/{series}/pts-cache.tar.gz |tar xz -C /var/tmp/pts-cache"
> +            fi
> +        else
> +            # Remove checkbox snap before testing.
> +            _run sudo snap remove {checkbox_snap_name}
> +            _run sudo snap remove {checkbox_snap_runtime}
> +
> +            # Install checkbox snap
> +            _run sudo snap install {checkbox_snap_runtime}
> +            _run sudo snap install {checkbox_snap_name} --channel={checkbox_snap_track}/{checkbox_snap_channel} --classic
> +            _run sudo DEBIAN_FRONTEND={debian_frontend} apt-get -qq install -o Dpkg::Options::="--force-confdef" -y --force-yes fswebcam obexftp wmctrl iperf mesa-utils vim pastebinit fwts xorg-dev gir1.2-clutter-1.0

Are these dependencies really necessary? For various reasons I question whether they should be installed e.g. xorg needed on server images? why vim and pastebinit? fwts should be included in the checkbox-core-snap so do we need the deb version?

>          fi
>  
>          if [ "{enable_proposed}" = "true" ]; then


-- 
https://code.launchpad.net/~kevinyeh/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/429501
Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master.