canonical-hw-cert team mailing list archive

[Paul Larson <mp+431871@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

A couple of small issues, otherwise looks good

Diff comments:

> diff --git a/snaps.yaml b/snaps.yaml
> index 4306c3c..f290f7f 100644
> --- a/snaps.yaml
> +++ b/snaps.yaml
> @@ -5,7 +5,7 @@ abb-dfa-apc2200-gadget:
>      Testflinger:
>        expected_tests:
>          - vasteras
> -abb-dfa-apc2200-kernel:
> +abb-dfa-apc2200-kernel: 

What happened here? was there a space accidentally added at the end or something?

>    arch: amd64
>    store: abbha9Ao5Eengooci8tu
>    checklists:
> @@ -549,7 +557,8 @@ core20:
>          - staunton
>          - advantech-uno-2271g-v2
>          - conroe
> -        - thinkedge-se30
> +	- thinkedge-se30

looks like you got a tab instead of spaces in front of thinkedge-se30

> +        - carlsbad
>  core22:
>    arch: amd64
>    store: ubuntu


-- 
https://code.launchpad.net/~kevinyeh/hwcert-jenkins-jobs/+git/hwcert-data/+merge/431871
Your team hwcert-jenkins is subscribed to branch ~canonical-hw-cert/hwcert-jenkins-jobs/+git/hwcert-data:master.