← Back to team overview

canonical-hw-cert team mailing list archive

Re: [Merge] ~kevinyeh/hwcert-jenkins-jobs:add-nuremberg-homegen2-suv into hwcert-jenkins-jobs:master

 

Review: Needs Fixing

Of the three test fails I think only the model-grade test could probably do with being excluded here (see below).

The other two:
  disk/storage_device_dm-1
  wireless/detect
lLook like checkbox bugs

Diff comments:

> diff --git a/jobs/snap-testing/launchers/nuremberg-homegen2-automated b/jobs/snap-testing/launchers/nuremberg-homegen2-automated
> new file mode 100644
> index 0000000..9712e54
> --- /dev/null
> +++ b/jobs/snap-testing/launchers/nuremberg-homegen2-automated
> @@ -0,0 +1,18 @@
> +# Please keep the indents below, for yaml formatting/templating
> +        [launcher]
> +        app_id = com.canonical.qa.nuremberg:checkbox
> +        launcher_version = 1
> +        stock_reports = text, submission_files, certification
> +        
> +        [test plan]
> +        unit = com.canonical.qa.nuremberg::homegen2-automated
> +        forced = yes
> +        
> +        [test selection]
> +        forced = yes

Could you add an exclusion for the image/model grade test please:

        [test selection]
        forced = yes
        exclude = com.canonical.certification::image/model-grade

> +        
> +        [ui]
> +        type = silent
> +        auto_retry = yes
> +        max_attempts = 4
> +        delay_before_retry = 30


-- 
https://code.launchpad.net/~kevinyeh/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/435012
Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master.



References