canonical-hw-cert team mailing list archive

[Rod Smith <mp+437965@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~rodsmith/maas-cert-server:add-disk-space-checks into maas-cert-server:master has been updated.

Description changed to:

Added an identical function, disk_space_check(), to both scripts, and called it twice in maniacs-setup (for the main installation and for mirroring the APT archive) and once in lxc-setup. Added control code around each call so that the scripts do reasonable things: Warn the user about inadequate space when installing MAAS in maniacs-setup and give the option to ignore the warning or proceed; terminate the APT mirroring operation in maniacs-setup; and terminate the LXC setup in lxc-setup.

The space limits are based on the observed sizes of the MAAS setup on weavile, the observed size of an APT mirror operation, and the size of the LXC container image created by lxc-setup.

I've tested the lxc-setup changes and the first call to maniacs-setup by running the full script (but with an "exit" command to terminate after the disk checks). The second call to disk_space_check() in maniacs-setup is untested "for real" because doing so would involve a full MAAS setup operation; however, it's a simple enough addition, and I tested the exact code I inserted by running it in a dummy program and it worked as expected there.

For more details, see:
https://code.launchpad.net/~rodsmith/maas-cert-server/+git/maas-cert-server/+merge/437965
-- 
Your team hardware-certification-users is requested to review the proposed merge of ~rodsmith/maas-cert-server:add-disk-space-checks into maas-cert-server:master.