canonical-hw-cert team mailing list archive

[Paul Larson <mp+438932@xxxxxxxxxxxxxxxxxx>]

Review: Needs Information

A couple of comments below

Diff comments:

> diff --git a/jobs/kivu/run-kivu.sh b/jobs/kivu/run-kivu.sh
> index 4dd109a..559336c 100644
> --- a/jobs/kivu/run-kivu.sh
> +++ b/jobs/kivu/run-kivu.sh
> @@ -42,14 +42,22 @@ cat > job.yaml <<EOF
>          mkdir -p artifacts
>          cp checkbox-launcher artifacts
>  
> +        # stop auto-upgrades
> +        _run sudo systemctl stop unattended-upgrades.service
> +        _run sudo systemctl stop apt-daily-upgrade.service

This might be enough, let's try it. But also be aware, that in the past, we've had to also do things like:
sudo cp /usr/share/unattended-upgrades/20auto-upgrades-disabled  /etc/apt/apt.conf.d/20auto-upgrades
sudo DEBIAN_FRONTEND=noninteractive apt-get remove unattended-upgrades -y --force-yes

This is in addition to a very long, and possibly overcomplicated script to ensure we really really really wait for automatic apt/dpkg processes to either finish or be killed off completely.

Unattended upgrades are notoriously persistent :(

> +
>          echo "preparing the system..."
>          _run sudo add-apt-repository -y universe
>          _run sudo apt-get -qq update
> -        _run sudo apt-get -qq install -y openssh-server pastebinit intel-gpu-tools intel-media-va-driver-non-free gstreamer1.0-vaapi gstreamer1.0-tools vainfo
> +        _run sudo apt-get -qq install -y openssh-server pastebinit intel-gpu-tools radeontop intel-media-va-driver-non-free gstreamer1.0-vaapi gstreamer1.0-tools vainfo mpv gnome-screensaver ydotool
> +        _run sudo apt-get -qq install -y wl-clipboard
> +        _run sudo add-apt-repository -y ppa:kivuteam/ppa
> +        _run sudo apt-get -qq update
> +        _run sudo apt-get -qq install -y gfxi
>          _run sudo apt-get -qq upgrade -y
>          _run sudo snap install --channel beta/hwacc chromium
>          _run sudo snap install checkbox22
> -        _run sudo snap install checkbox-kivu-classic --classic
> +        _run sudo snap install --channel latest/edge checkbox-kivu-classic --classic
>  
>          echo Starting
>          # DISPLAY=:0 to make sure graphic test jobs were tested expectedly (not necessary in remote)
> @@ -66,6 +74,19 @@ cat > job.yaml <<EOF
>          mv submission.json artifacts
>          echo "Files in artifacts:"
>          ls artifacts
> +
> +        # cleanup (do not remove everything because some package can be already here ..)
> +        _run sudo snap remove checkbox-kivu-classic
> +        _run sudo snap remove checkbox22
> +        _run sudo snap remove chromium
> +        _run sudo apt-get remove -y gfxi
> +        _run sudo add-apt-repository -d -y ppa:kivuteam/ppa
> +        _run sudo apt-get remove -y wl-clipboard
> +        _run sudo apt-get remove -y pastebinit intel-gpu-tools radeontop intel-media-va-driver-non-free gstreamer1.0-vaapi gstreamer1.0-tools mpv gnome-screensaver ydotool
> +
> +        # restart auto-upgrades
> +        _run sudo systemctl start unattended-upgrades.service
> +        _run sudo systemctl start apt-daily-upgrade.service

Since the system is provisioned, I don't think it makes any sense to spend time removing packages and re-enabling things here. Unless there's some other reason for this that I don't see?

>  EOF
>  
>  #Remove previous venv


-- 
https://code.launchpad.net/~hwcert-jenkins/hwcert-jenkins-jobs/+git/hwcert-jenkins-jobs/+merge/438932
Your team hwcert-jenkins is subscribed to branch hwcert-jenkins-jobs:master.