← Back to team overview

canonical-ubuntu-qa team mailing list archive

Re: [Merge] ~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2:update_pipeline into autopkgtest-cloud:master

 

Review: Needs Resubmitting

Please make two separate MPs for the two changes. I know both changes touch lpci stuff, but they are really separate (one drop a pipeline, the other adds a new unrelated one).

It may feel wasteful to open many MPs, but doing so will make our review iterations faster!

---

I know changes are split in different commits, but what we normally review is the whole diff at once (at least in the classic GitHub/LP style review workflow, Gerrit has commit-by-commit reviews).

I think it's useful to think as if we were squash merges of features branches (= branches are merged squashed), a great workflow some projects use (e.g. cloud-init).
-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud-2/+merge/443815
Your team Canonical's Ubuntu QA is subscribed to branch autopkgtest-cloud:master.



References