canonical-ubuntu-qa team mailing list archive

Thread
Date

[Merge] ~andersson123/auto-upgrade-testing-specifications:check_conf_file_prompt into auto-upgrade-testing-specifications:main

To: mp+444554@xxxxxxxxxxxxxxxxxx
From: Tim Andersson <mp+444554@xxxxxxxxxxxxxxxxxx>
Date: Mon, 12 Jun 2023 11:56:17 -0000
Reply-to: mp+444554@xxxxxxxxxxxxxxxxxx
Sender: noreply@xxxxxxxxxxxxx

Tim Andersson has proposed merging ~andersson123/auto-upgrade-testing-specifications:check_conf_file_prompt into auto-upgrade-testing-specifications:main.

Commit message:
add check for conf file prompt in upgrade log

Requested reviews:
  Canonical Platform QA Team (canonical-platform-qa)

For more details, see:
https://code.launchpad.net/~andersson123/auto-upgrade-testing-specifications/+git/auto-upgrade-testing-specifications/+merge/444554

add check for conf file prompt in upgrade log
-- 
Your team Canonical Platform QA Team is requested to review the proposed merge of ~andersson123/auto-upgrade-testing-specifications:check_conf_file_prompt into auto-upgrade-testing-specifications:main.

diff --git a/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml b/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
index e084a89..5483b24 100644
--- a/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
@@ -14,4 +14,5 @@
     - "rcS-workaround"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml b/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
index e609927..d149372 100644
--- a/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
@@ -16,6 +16,7 @@
     - "rcS-workaround"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
diff --git a/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
index 1c3850a..66086d3 100644
--- a/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
@@ -14,4 +14,5 @@
     - "null"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
index 675a623..ef33da4 100644
--- a/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
@@ -16,6 +16,7 @@
     - "check-ubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
diff --git a/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
index 61f5810..033fa18 100644
--- a/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-kubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
index 8085669..f489485 100644
--- a/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-lubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
index b882c6c..3c157a5 100644
--- a/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntu-mate-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
index 141be2f..b68091d 100644
--- a/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-xubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml
index 8b5d30b..30c9ad1 100644
--- a/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-kinetic-basic-amd64_qemu.yaml
@@ -14,4 +14,5 @@
     - "null"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml
index f6ccb7c..4a49997 100644
--- a/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-kinetic-desktop-amd64_qemu.yaml
@@ -16,6 +16,7 @@
     - "check-ubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
diff --git a/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml
index 7a0b349..49f7393 100644
--- a/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-kinetic-kubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-kubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml
index e7ac21d..146c1d4 100644
--- a/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-kinetic-lubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-lubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml
index e964479..17d8eba 100644
--- a/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-kinetic-ubuntu-mate-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntu-mate-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml
index 1333af6..a8c3930 100644
--- a/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-kinetic-xubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-xubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml
index 6554ea5..fac51d5 100644
--- a/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-basic-amd64_qemu.yaml
@@ -14,4 +14,5 @@
     - "null"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml
index 8b456e6..8756c58 100644
--- a/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-desktop-amd64_qemu.yaml
@@ -16,6 +16,7 @@
     - "check-ubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
diff --git a/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml
index 03e4833..6e444f6 100644
--- a/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-kubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-kubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml
index 35ee6b6..e01dc48 100644
--- a/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-lubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-lubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml
index 01e7d99..39e4cea 100644
--- a/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-ubuntu-mate-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntu-mate-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-kinetic-lunar-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-ubuntu-unity-amd64_qemu.yaml
index 47d8060..93a07bd 100644
--- a/profiles/ubuntu-kinetic-lunar-ubuntu-unity-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-ubuntu-unity-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntu-unity-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
\ No newline at end of file
diff --git a/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml
index b55de23..7913841 100644
--- a/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-kinetic-lunar-xubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-xubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml
index 7225a63..69d119a 100644
--- a/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml
@@ -14,4 +14,5 @@
     - "null"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
\ No newline at end of file
diff --git a/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml
index 7ed303b..cc25e68 100644
--- a/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml
@@ -16,6 +16,7 @@
     - "check-ubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
\ No newline at end of file
diff --git a/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml
index 8b77ec5..b181a2b 100644
--- a/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml
@@ -15,4 +15,5 @@
     - "check-kubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml
index 1a264be..a55513a 100644
--- a/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-lubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml
index 07f0fbe..4c88f3f 100644
--- a/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntu-mate-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
\ No newline at end of file
diff --git a/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
index 5d7850d..681dc07 100644
--- a/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntu-unity-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
\ No newline at end of file
diff --git a/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml
index 9b5e2bf..103b112 100644
--- a/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-ubuntucinnamon-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
\ No newline at end of file
diff --git a/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml
index caaf497..00484fd 100644
--- a/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml
@@ -16,4 +16,5 @@
     - "check-xubuntu-desktop"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml b/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml
index 3fdfc07..d5b5f63 100644
--- a/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-xenial-bionic-basic-amd64_qemu.yaml
@@ -14,4 +14,5 @@
     - "rcS-workaround"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml b/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml
index 9b3e2f1..511e057 100644
--- a/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml
+++ b/profiles/ubuntu-xenial-bionic-basic-i386_qemu.yaml
@@ -14,4 +14,5 @@
     - "rcS-workaround"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
diff --git a/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml b/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml
index 0e1d18c..bc96a97 100644
--- a/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-xenial-bionic-desktop-amd64_qemu.yaml
@@ -16,6 +16,7 @@
     - "rcS-workaround"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
diff --git a/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml b/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml
index 6e11443..bd99f51 100644
--- a/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml
+++ b/profiles/ubuntu-xenial-bionic-desktop-i386_qemu.yaml
@@ -16,6 +16,7 @@
     - "rcS-workaround"
 
   post_upgrade_tests:
+    - "check-conf-file-prompt"
     - "check-var-crash-empty"
 
   run_system_tests: true
diff --git a/tests/check-conf-file-prompt b/tests/check-conf-file-prompt
new file mode 100755
index 0000000..007fedf
--- /dev/null
+++ b/tests/check-conf-file-prompt
@@ -0,0 +1,22 @@
+#!/bin/bash
+
+LOG_FILE_PATH="/var/log/dist-upgrade/main.log"
+
+# First of all, check log file actually exists.
+if ! test -f "${LOG_FILE_PATH}"; then
+    printf "No dist upgrade log, something must have gone wrong.\n"
+    exit 1
+fi
+
+MAGIC_EXIT_NUM=1
+CHECK_ME="WARNING got a conffile-prompt from dpkg"
+output=""
+
+# Now check the log file for conffile prompts
+if grep -q "${CHECK_ME}" "${LOG_FILE_PATH}"; then
+    output=$(grep -A 5 -B 5 -R "${CHECK_ME}" "${LOG_FILE_PATH}")
+    printf "Conf file prompts found in log file for dist-upgrade, marking as unstable/failure. Log snippet:\n%s\n" "${output}"
+    exit "${MAGIC_EXIT_NUM}"
+fi
+
+printf "No conf file prompts found in log file for dist-upgrade, success."
\ No newline at end of file