canonical-ubuntu-qa team mailing list archive

[Paride Legovini <mp+444727@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

What's the plan here more precisely? What is actually going to `exit 75`?

My idea is to grep the log (path: {profile}/*.*/log) for the signature of a debconf question, and `exit 75` in that case. However I think it's better to do that in a separate builder.

builders:
  - clear-artifacts
  - shell: |
      [current upgrade testing script]
  - shell:
      unstable-return: 75
      command: |
        [log parsing logic goes here]

Apart from this, one online comment.

Diff comments:

> diff --git a/jobs/auto-upgrade-testing/jobs.yaml b/jobs/auto-upgrade-testing/jobs.yaml
> index da95123..ae1de0b 100644
> --- a/jobs/auto-upgrade-testing/jobs.yaml
> +++ b/jobs/auto-upgrade-testing/jobs.yaml
> @@ -42,7 +42,9 @@
>              gitvarprefix: AUTS
>      builders:
>          - clear-artifacts:
> -        - shell: |
> +        - shell:
> +            unstable-return: 75
> +            command: |
>              git clone -b "$AUTBRANCH" --depth=1 "$AUTREPO" auto-upgrade-testing || exit 1

I believe there is an indentation issue here: the commands need an extra indent:

command: |
  foo
  bar

>              git clone -b "$AUTSBRANCH" --depth=1 "$AUTSREPO" auto-upgrade-testing-specifications || exit 1
>  


-- 
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/444727
Your team Canonical Platform QA Team is subscribed to branch qa-jenkins-jobs:master.