canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+445630@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/.launchpad.yaml b/.launchpad.yaml
> index a744b71..bec3a7d 100755
> --- a/.launchpad.yaml
> +++ b/.launchpad.yaml
> @@ -1,16 +1,39 @@
>  pipeline:
>    - pre_commit
>    - build_charms
> -  - lint_test
>  
>  jobs:
>    pre_commit:
> -    series: jammy
> +    series: focal
>      architectures: amd64
> +    package-repositories:
> +      - type: apt
> +        formats: [deb]
> +        suites: [focal]
> +        ppa: paride/pre-commit-backports
> +    snaps:
> +      - name: yq
>      packages:
>        - git
>        - pre-commit
> -    run: pre-commit run --all-files --show-diff-on-failure
> +      - pylint
> +      # These are not directly declared in layer.yaml.
> +      # Maybe they are brought in by some included layer?
> +      - python3-systemd
> +      - python3-apt
> +    run-before: |
> +      # Install dependencies as declared in the layer files
> +      DEBIAN_FRONTEND=noninteractive \
> +        apt-get install -qy \
> +        $(cat charms/focal/autopkgtest-cloud-worker/layer.yaml | \
> +          yq -r '.options.basic.packages[]') \
> +        $(cat charms/focal/autopkgtest-cloud-worker/layer.yaml | \
> +          yq -r '.options.apt.packages[]') \
> +        $(cat charms/focal/autopkgtest-web/layer.yaml | \
> +          yq -r '.options.apt.packages[]') \
> +        $(cat charms/focal/autopkgtest-web/layer.yaml | \
> +          yq -r '.options.basic.packages[]')
> +    run: pre-commit run --hook-stage manual --all-files --show-diff-on-failure

There isn't a way to absorb deps from a file in lpci so this is the best way to do it I think.

>    build_charms:
>      series: focal
>      architectures: amd64


-- 
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445630
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~paride/autopkgtest-cloud:pre-commit-pylint into autopkgtest-cloud:master.