canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+445630@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
> index 0735120..d3bc39f 100644
> --- a/.pre-commit-config.yaml
> +++ b/.pre-commit-config.yaml
> @@ -22,3 +22,28 @@ repos:
>      rev: 5.12.0
>      hooks:
>        - id: isort
> +  - repo: local
> +    hooks:
> +      # Run pylint with --disable import-error.
> +      # This is meant to run on developers' machines where not all the
> +      # Python modules may be installed.
> +      - id: pylint
> +        name: pylint
> +        stages:
> +          [commit-msg, post-checkout, post-commit, post-merge, post-rewrite,
> +           pre-commit, pre-merge-commit, pre-push, pre-rebase,
> +           prepare-commit-msg]
> +        entry: pylint
> +        args:
> +          - "--disable=import-error"
> +        language: system
> +        types: [python]
> +      # Run pylint without disabling import-error.
> +      # This is meant to run in CI (pre-commit run --hook-stage manual).
> +      # The CI environment is expected to have all the required dependencies.
> +      - id: pylint
> +        name: pylint (with import errors)
> +        stages: [manual]
> +        entry: pylint
> +        language: system
> +        types: [python]

will pylint be run in ci with and without the disable? I'm probably missing it but is the disable one only configured to run locally?



-- 
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445630
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~paride/autopkgtest-cloud:pre-commit-pylint into autopkgtest-cloud:master.