canonical-ubuntu-qa team mailing list archive

[Paride Legovini <mp+445630@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/.pylintrc b/.pylintrc
> index a831f0a..b6b77fa 100644
> --- a/.pylintrc
> +++ b/.pylintrc
> @@ -2,4 +2,48 @@
>  
>  jobs=0
>  
> -disable=invalid-name, import-error, no-name-in-module
> +[MESSAGES CONTROL]
> +
> +disable=
> +  R,
> +  anomalous-backslash-in-string,
> +  arguments-differ,
> +  bad-continuation,  # leave this to black
> +  bad-option-value,  # for older versions of pylint
> +  broad-except,
> +  broad-exception-caught,
> +  consider-using-f-string,
> +  duplicate-string-formatting-argument,
> +  fixme,
> +  global-statement,
> +  global-variable-not-assigned,
> +  invalid-name,
> +  logging-format-interpolation,
> +  logging-fstring-interpolation,
> +  logging-not-lazy,
> +  missing-class-docstring,
> +  missing-function-docstring,
> +  missing-module-docstring,

We don't want pylint to complain about those right now. The "right" way to add new linters to larger codebases would be:

1. add the linter, disable all failing rules
2. CI will pass (failing rules are disabled).
3. enable one rule, make it pass or disable it in individual lines/files
4. proposed for merging, CI will pass
5. iterate points 3 and 4

Think of this MP containing quite some of this iteration already.

> +  missing-timeout,
> +  possibly-unused-variable,
> +  protected-access,
> +  redefined-builtin,
> +  redefined-outer-name,
> +  unspecified-encoding,
> +  unused-argument,
> +  wrong-import-order,  # leave this to isort
> +
> +[REPORTS]
> +
> +# Show just the errors, no full report
> +reports=no
> +score=no
> +
> +[TYPECHECK]
> +
> +ignored-modules=
> +  amulet,
> +  charmhelpers,
> +  charms,
> +  lib,
> +  utils,


-- 
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/445630
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~paride/autopkgtest-cloud:pre-commit-pylint into autopkgtest-cloud:master.