canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+447886@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> index 1e31008..998bd73 100644
> --- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> +++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
> @@ -552,12 +552,16 @@ class Submit:
>                  releases = data[pkg][submitted].keys()
>                  for release in data[pkg][submitted]:
>                      architectures = data[pkg][submitted][release].keys()
> -                    triggers = submitted[submitted.find(";triggers_") + 1 :]
> -                    triggers = triggers[: triggers.find(";")]
> -                    triggers = triggers[
> -                        triggers.find("[") + 1 : triggers.find("]")
> -                    ]
> -                    triggers = triggers.replace("'", "").split(", ")
> +                    triggers = []
> +                    if submitted.find(";triggers_") != -1:
> +                        triggers = submitted[
> +                            submitted.find(";triggers_") + 1 :
> +                        ]
> +                        triggers = triggers[: triggers.find(";")]
> +                        triggers = triggers[
> +                            triggers.find("[") + 1 : triggers.find("]")
> +                        ]
> +                        triggers = triggers.replace("'", "").split(", ")

It's a string of a json within an actual json

>                      if (
>                          req_arch in architectures
>                          and req_series in releases


-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/447886
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:fix_traceback into autopkgtest-cloud:master.