canonical-ubuntu-qa team mailing list archive

[Paride Legovini <mp+447973@xxxxxxxxxxxxxxxxxx>]

One nitty comment, otherwise LGTM.

Diff comments:

> diff --git a/charms/focal/autopkgtest-web/webcontrol/browse.cgi b/charms/focal/autopkgtest-web/webcontrol/browse.cgi
> index d7d7146..e0be36b 100755
> --- a/charms/focal/autopkgtest-web/webcontrol/browse.cgi
> +++ b/charms/focal/autopkgtest-web/webcontrol/browse.cgi
> @@ -158,8 +157,7 @@ def get_queue_info():
>                      ctx.setdefault(context, {}).setdefault(release, {})[
>                          arch
>                      ] = (size, requests)
> -

Extra newline dropped (it was good formatting to have the return separated from the previous for loop).

> -        return (releases, arches, ctx)
> +        return (SUPPORTED_UBUNTU_RELEASES, arches, ctx)
>  
>  
>  def get_source_versions(db, release):


-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/447973
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:fix_running_webpage into autopkgtest-cloud:master.