canonical-ubuntu-qa team mailing list archive

[Brian Murray <mp+448023@xxxxxxxxxxxxxxxxxx>]

Brian Murray has proposed merging autopkgtest-cloud:full-allowed-teams into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/448023

Until we have resolved the our use of the Launchpad API to find all the members of the autopkgtest-requestors team we should add all the teams which make up autopkgtest-requestors. This will avoid us carrying a cowboy in production - which is not the best idea.
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of autopkgtest-cloud:full-allowed-teams into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-web/webcontrol/request/submit.py b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
index 3ab0ca3..501f064 100644
--- a/charms/focal/autopkgtest-web/webcontrol/request/submit.py
+++ b/charms/focal/autopkgtest-web/webcontrol/request/submit.py
@@ -32,7 +32,9 @@ ENV = re.compile(r"^[a-zA-Z][a-zA-Z0-9_]+=[a-zA-Z0-9.:~/ -=]*$")
 # URL and optional branch name
 GIT = re.compile(r"^https?://[a-zA-Z0-9._/~+-]+(#[a-zA-Z0-9._/-]+)?$")
 
-ALLOWED_TEAMS = ["canonical-kernel-distro-team", "autopkgtest-requestors"]
+ALLOWED_TEAMS = ["canonical-kernel-distro-team", "autopkgtest-requestors",
+                 "canonical-partner-eng", "canonical-server",
+                 "canonical-foundations", "canonical-ubuntu-qa"]
 # not teams
 ALLOWED_USERS_PERPACKAGE = {"snapcraft": ["snappy-m-o"]}