canonical-ubuntu-qa team mailing list archive

[Brian Murray <mp+456987@xxxxxxxxxxxxxxxxxx>]

I've a couple of more comments.

Diff comments:

> diff --git a/docs/lxd.rst b/docs/lxd.rst
> index 1f88c67..f6e9b46 100644
> --- a/docs/lxd.rst
> +++ b/docs/lxd.rst
> @@ -2,7 +2,7 @@ Tests on LXD
>  ============
>  
>  Ubuntu's ``armhf`` tests currently run inside LXD containers on ``arm64``
> -hosts. Each host is a ``cpu4-ram8-disk100`` cloud instance, and can run up to
> +hosts. Each host is a ``m1.xlarge`` cloud instance, and can run up to

I think instead of using the name of the flavor again we should specify what we want the arm64 units to be e.g. `Each host is a cloud instance with cpu4-ram16-disk100`.

>  3 parallel tests. These hosts are statically assigned, in that they stay
>  around as long as they're working.
>  
> @@ -29,7 +29,7 @@ To deploy a new node, after having sourced the cloud ``.rc`` file:
>  
>      $ IMAGE=$(openstack image list --format csv -c Name --quote none | grep auto-sync/ubuntu-focal-daily-arm64-server | tail -n1)
>      $ NET_ID=$(openstack network show net_prod-proposed-migration --format json | jq -r '."id"')
> -    $ openstack server create --image $IMAGE --flavor cpu8-ram8-disk100 --nic net-id=$NET_ID --key-name wendigo --security-group default --security-group lxd --user-data ~/autopkgtest-cloud/autopkgtest-cloud/tools/armhf-lxd.userdata -- lxd-armhfN
> +    $ openstack server create --image $IMAGE --flavor m1.xlarge --nic net-id=$NET_ID --key-name wendigo --security-group default --security-group lxd --user-data ~/autopkgtest-cloud/autopkgtest-cloud/tools/armhf-lxd.userdata -- lxd-armhfN

Let's also update the `--key-name` argument here.

>  
>  In the event that you want to deploy the new node on a specifc host you can use the ``--hint same_host`` argument e.g. ``openstack server create --hint same_host=2e838a71-f6d9-46c4-94f9-dd0c6a2632fe``.
>  
> @@ -87,7 +87,7 @@ juju environment and execute ``mojo run`` on the controller.
>  
>      $ IMAGE=$(openstack image list --format csv -c Name --quote none | grep auto-sync/ubuntu-focal-daily-amd64-server | tail -n1)

Not amd64.

>      $ NET_ID=$(openstack network show net_prod-proposed-migration --format json | jq -r '."id"')
> -    $ nova boot --image $IMAGE --flavor cpu4-ram8-disk50 --nic net-id=$NET_ID --key_name wendigo --security-groups default,lxd --user-data <(autopkgtest-cloud/autopkgtest-cloud/tools/create-armhf-cluster-member TYPE [IP]) -- lxd-armhfN
> +    $ nova boot --image $IMAGE --flavor m1.xlarge --nic net-id=$NET_ID --key_name wendigo --security-groups default,lxd --user-data <(autopkgtest-cloud/autopkgtest-cloud/tools/create-armhf-cluster-member TYPE [IP]) -- lxd-armhfN

While this is commented out if we are going to update it let's also update the `--key_name` argument to `--key-name` and with the right option.

>  
>    Where ``TYPE`` is one of:
>  


-- 
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/456987
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:update-docs-lxd-flavor into autopkgtest-cloud:master.