canonical-ubuntu-qa team mailing list archive

[Brian Murray <mp+457169@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> diff --git a/lib/adt_testbed.py b/lib/adt_testbed.py
> index 3ea08fa..a5ceeae 100644
> --- a/lib/adt_testbed.py
> +++ b/lib/adt_testbed.py
> @@ -1368,7 +1368,7 @@ Description: satisfy autopkgtest test dependencies
>  
>          # translate src:name entries into binaries of that source
>          if srcpkgs:
> -            script += 'PKGS="$PKGS $(apt-cache showsrc %s | ' \
> +            script += 'PKGS="$PKGS $((apt-cache showsrc e2fsprogs 3>&1 1>&2 2>&3 3>&- | grep -v ^W: ) 3>&1 1>&2 2>&3 3>&- | ' \

Where did the %s go?

>                  '''awk '/^Package-List:/ { show=1; next } (/^ / && show==1) { print $1 ":*"; next } { show=0 }' |''' \
>                  '''sort -u | tr '\\n' ' ')"; ''' % \
>                  ' '.join(srcpkgs)


-- 
https://code.launchpad.net/~ubuntu-release/autopkgtest/+git/development/+merge/457169
Your team Canonical's Ubuntu QA is subscribed to branch ~ubuntu-release/autopkgtest/+git/development:master.