canonical-ubuntu-qa team mailing list archive
-
canonical-ubuntu-qa team
-
Mailing list archive
-
Message #02542
[Merge] ~hyask/auto-upgrade-testing-specifications:skia/var_crash_ignore_list into auto-upgrade-testing-specifications:main
Skia has proposed merging ~hyask/auto-upgrade-testing-specifications:skia/var_crash_ignore_list into auto-upgrade-testing-specifications:main.
Requested reviews:
Canonical Platform QA Team (canonical-platform-qa)
For more details, see:
https://code.launchpad.net/~hyask/auto-upgrade-testing-specifications/+git/auto-upgrade-testing-specifications/+merge/458928
This is still waiting for the profiles completions with the real ignore-list we want.
Note: this needs to merge at the same time as this PR: https://github.com/canonical/auto-upgrade-testing/pull/9
--
Your team Canonical Platform QA Team is requested to review the proposed merge of ~hyask/auto-upgrade-testing-specifications:skia/var_crash_ignore_list into auto-upgrade-testing-specifications:main.
diff --git a/examples/specifications/example-test-specification.yaml b/examples/specifications/example-test-specification.yaml
index a2c1543..4067b65 100644
--- a/examples/specifications/example-test-specification.yaml
+++ b/examples/specifications/example-test-specification.yaml
@@ -5,13 +5,13 @@
# Script location can be a local path.
# A relative path (i.e. starting either with ./ or ../) is relative to the
# location of the specification file.
- script_location: file://./tests
+ scripts_location: file://./tests
# Or a bzr path to the location (that will be exported).
- script_location: lp:auto-upgrade-testing-specifications/
+ scripts_location: lp:auto-upgrade-testing-specifications/
# Backend arguments are passed through to the adt-run backend section
- # {script_location} can be used here
- backend_args: --needed-file={script_location}/../resources/file.ext
+ # {scripts_location} can be used here
+ backend_args: --needed-file={scripts_location}/../resources/file.ext
# There are 2 stages of scripts/tests that are run.
# - pre_upgrade_scripts: These are run after the backend has been
@@ -28,6 +28,19 @@
- "test_pass"
- "test_fail"
+ # This data structure will be available for any script to use on the testbed.
+ # It is located in the `cwd` of each script, and named `scripts_data.json`.
+ scripts_data:
+ # Used by the `check-var-crash-empty` script
+ var_crash_ignore_list:
+ # Pattern given to pathlib.Path.glob in Python
+ - pattern: "libtestcrashes*.crash"
+ # Date after which we'll stop masking this crash and start failing again, for reminder
+ expiry_date: "2024-01-17"
+ # Mandatory bug link allowing adding an entry to this list
+ bug_link: "https://bugs.launchpad.net/bugs/4000";
+
+
# Or you can define a directory where each executable found within will be
# run
# A relative path (i.e. starting either with ./ or ../) is relative to the
diff --git a/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml b/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
index 0862757..51e4a7a 100644
--- a/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-bionic-focal-basic-amd64_qemu.yaml
@@ -9,7 +9,7 @@
- "bionic"
- "focal"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "rcS-workaround"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml b/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
index 5b1fed1..b40f658 100644
--- a/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-bionic-focal-desktop-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "bionic"
- "focal"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "rcS-workaround"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
index 55511d0..d31a267 100644
--- a/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-basic-amd64_qemu.yaml
@@ -9,7 +9,7 @@
- "focal"
- "jammy"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "null"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
index c40b1f2..6de554f 100644
--- a/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-desktop-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "focal"
- "jammy"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
index 7731cab..8b658bc 100644
--- a/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-kubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "focal"
- "jammy"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-kubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
index 5a5ecf5..0a23c95 100644
--- a/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-lubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "focal"
- "jammy"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-lubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
index cb1e83e..dec8ff3 100644
--- a/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-ubuntu-mate-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "focal"
- "jammy"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-mate-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
index c3731ac..3ada5d3 100644
--- a/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-focal-jammy-xubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "focal"
- "jammy"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-xubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-basic-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-basic-amd64_qemu.yaml
index c6edffe..5c6d726 100644
--- a/profiles/ubuntu-jammy-lunar-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-basic-amd64_qemu.yaml
@@ -9,7 +9,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "enable-apport-noui"
- "force-prompt-normal"
diff --git a/profiles/ubuntu-jammy-lunar-desktop-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-desktop-amd64_qemu.yaml
index 29b866b..08871d5 100644
--- a/profiles/ubuntu-jammy-lunar-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-desktop-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-kubuntu-amd64_qemu.yaml
index b8104fd..c02fca4 100644
--- a/profiles/ubuntu-jammy-lunar-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-kubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-kubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-lubuntu-amd64_qemu.yaml
index 96f9828..a77c44f 100644
--- a/profiles/ubuntu-jammy-lunar-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-lubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-lubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-server-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-server-amd64_qemu.yaml
index 0edb5e5..02200d9 100644
--- a/profiles/ubuntu-jammy-lunar-server-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-server-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-server"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-ubuntu-mate-amd64_qemu.yaml
index 0f0ec94..81f17e6 100644
--- a/profiles/ubuntu-jammy-lunar-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-ubuntu-mate-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-mate-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-ubuntu-unity-amd64_qemu.yaml
index b8e6bd6..bb6c31a 100644
--- a/profiles/ubuntu-jammy-lunar-ubuntu-unity-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-ubuntu-unity-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-unity-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-lunar-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-lunar-xubuntu-amd64_qemu.yaml
index 349d331..fb1cbb2 100644
--- a/profiles/ubuntu-jammy-lunar-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-lunar-xubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "lunar"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-xubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-basic-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-basic-amd64_qemu.yaml
index e26209e..eaccfb0 100644
--- a/profiles/ubuntu-jammy-noble-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-basic-amd64_qemu.yaml
@@ -9,7 +9,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "rcS-workaround"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-desktop-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-desktop-amd64_qemu.yaml
index 11ca733..9dd1f74 100644
--- a/profiles/ubuntu-jammy-noble-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-desktop-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "rcS-workaround"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-kubuntu-amd64_qemu.yaml
index ac69577..4a58eb6 100644
--- a/profiles/ubuntu-jammy-noble-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-kubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-kubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-lubuntu-amd64_qemu.yaml
index 779714d..2762826 100644
--- a/profiles/ubuntu-jammy-noble-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-lubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-lubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-server-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-server-amd64_qemu.yaml
index 64f7385..5e99496 100644
--- a/profiles/ubuntu-jammy-noble-server-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-server-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-server"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-ubuntu-mate-amd64_qemu.yaml
index bceccde..ffc9614 100644
--- a/profiles/ubuntu-jammy-noble-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-ubuntu-mate-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-mate-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-ubuntu-unity-amd64_qemu.yaml
index c527c5e..36f8f04 100644
--- a/profiles/ubuntu-jammy-noble-ubuntu-unity-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-ubuntu-unity-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-unity-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-jammy-noble-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-jammy-noble-xubuntu-amd64_qemu.yaml
index d1d4b3a..cfd3653 100644
--- a/profiles/ubuntu-jammy-noble-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-jammy-noble-xubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "jammy"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-xubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml
index e3f6000..38c7cb8 100644
--- a/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-basic-amd64_qemu.yaml
@@ -9,7 +9,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "null"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml
index 336a6ce..c041eb5 100644
--- a/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-desktop-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml
index 5d7abbc..def9fd4 100644
--- a/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-kubuntu-amd64_qemu.yaml
@@ -10,7 +10,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-kubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml
index 627e25a..39d7cd6 100644
--- a/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-lubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-lubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-server-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-server-amd64_qemu.yaml
index a3659a1..8315a05 100644
--- a/profiles/ubuntu-lunar-mantic-server-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-server-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-server"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml
index d349c85..695866f 100644
--- a/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-ubuntu-mate-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-mate-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
index 61e3431..12320c7 100644
--- a/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-ubuntu-unity-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-unity-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml
index f4a561a..2e173b1 100644
--- a/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-ubuntucinnamon-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntucinnamon-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml
index 3b3c43b..7f08993 100644
--- a/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-lunar-mantic-xubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "lunar"
- "mantic"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-xubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-basic-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-basic-amd64_qemu.yaml
index 488411a..30af0fd 100644
--- a/profiles/ubuntu-mantic-noble-basic-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-basic-amd64_qemu.yaml
@@ -9,7 +9,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "rcS-workaround"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-desktop-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-desktop-amd64_qemu.yaml
index 1479bc5..3ee8d39 100644
--- a/profiles/ubuntu-mantic-noble-desktop-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-desktop-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "rcS-workaround"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-kubuntu-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-kubuntu-amd64_qemu.yaml
index 13a0373..3dfa5d0 100644
--- a/profiles/ubuntu-mantic-noble-kubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-kubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-kubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-lubuntu-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-lubuntu-amd64_qemu.yaml
index b8c5d2e..c64dea1 100644
--- a/profiles/ubuntu-mantic-noble-lubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-lubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-lubuntu-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-server-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-server-amd64_qemu.yaml
index 77dd20f..33fa2ab 100644
--- a/profiles/ubuntu-mantic-noble-server-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-server-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-server"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-ubuntu-mate-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-ubuntu-mate-amd64_qemu.yaml
index b48c9fa..8173f81 100644
--- a/profiles/ubuntu-mantic-noble-ubuntu-mate-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-ubuntu-mate-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-mate-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-ubuntu-unity-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-ubuntu-unity-amd64_qemu.yaml
index c097fe9..d32c79d 100644
--- a/profiles/ubuntu-mantic-noble-ubuntu-unity-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-ubuntu-unity-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntu-unity-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-ubuntucinnamon-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-ubuntucinnamon-amd64_qemu.yaml
index 39f0fe9..a79c797 100644
--- a/profiles/ubuntu-mantic-noble-ubuntucinnamon-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-ubuntucinnamon-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-ubuntucinnamon-desktop"
- "enable-apport-noui"
diff --git a/profiles/ubuntu-mantic-noble-xubuntu-amd64_qemu.yaml b/profiles/ubuntu-mantic-noble-xubuntu-amd64_qemu.yaml
index 4f57449..8d99032 100644
--- a/profiles/ubuntu-mantic-noble-xubuntu-amd64_qemu.yaml
+++ b/profiles/ubuntu-mantic-noble-xubuntu-amd64_qemu.yaml
@@ -11,7 +11,7 @@
- "mantic"
- "noble"
- script_location: file://../tests
+ scripts_location: file://../tests
pre_upgrade_scripts:
- "check-xubuntu-desktop"
- "enable-apport-noui"
diff --git a/tests/check-var-crash-empty b/tests/check-var-crash-empty
index db856b4..04e8a7a 100755
--- a/tests/check-var-crash-empty
+++ b/tests/check-var-crash-empty
@@ -1,17 +1,85 @@
-#!/bin/sh
+#!/usr/bin/env python3
-set -e
+import json
+import sys
+import subprocess
+from datetime import date
+from pathlib import Path
-crashdir=/var/crash
-echo "Checking for (absence of) crash files in $crashdir."
+print("#### Checking /var/crash ####")
-if find "$crashdir" -maxdepth 0 ! -empty -exec false {} +; then
- echo "PASS: $crashdir is empty (good)"
-else
- echo "FAIL: $crashdir is not empty. Crash files sorted by creation time:"
- ls -gGh -tr --time=creation --full-time "$crashdir"
- sudo systemctl start whoopsie.service --wait
- find /var/crash -name "*.uploaded" -exec tail -n +1 {} +
- exit 1
-fi
+print("Ensuring `whoopsie` is finished running")
+try:
+ subprocess.run(
+ ["sudo", "systemctl", "start", "whoopsie.service", "--wait"],
+ check=True,
+ )
+except subprocess.CalledProcessError as e:
+ print(f"\tError waiting for `whoopsie` ({e}), continuing anyway")
+ print(f"\tstdout: {e.stdout}")
+ print(f"\tstderr: {e.stderr}")
+
+today = date.today()
+print(f"Today is {today}")
+
+try:
+ data_path = Path("scripts_data.json")
+ with open(data_path) as f:
+ data = json.load(f)
+ ignore_list = data["var_crash_ignore_list"]
+ print(f"Loaded ignore list from `scripts_data.json`: {ignore_list}")
+except Exception as e:
+ ignore_list = []
+ print(f"Failed to load ignore list from `scripts_data.json`: {e}")
+
+crash_list = []
+
+for crash in Path("/var/crash").glob("*.crash"):
+ print(f"Found crash `{crash}`")
+
+ uploaded_file = crash.with_suffix(".uploaded")
+ try:
+ info = uploaded_file.read_text().strip()
+ print(f"\tUpload details: {info}")
+ except FileNotFoundError:
+ print(f"\t{uploaded_file} not found, there's no detail to display")
+
+ print("\tChecking against ignore list")
+ for entry in ignore_list:
+ expiry_date = date.fromisoformat(entry["expiry_date"])
+ pattern = entry["pattern"]
+ print(
+ f"\t\tChecking against `{pattern}` (expires on {expiry_date}) ... ",
+ end="",
+ )
+ if crash.match(pattern):
+ if expiry_date <= today:
+ print(
+ f"matched expired entry, reporting the crash (please fix that bug: {entry['bug_link']})"
+ )
+ crash_list.append(crash)
+ else:
+ print(
+ f"matched, ignoring the crash (details should be here: {entry['bug_link']})"
+ )
+ break
+ else:
+ print("no match")
+ else:
+ print("\tNo entry matched, reporting this crash")
+ crash_list.append(crash)
+
+exit_code = 0
+
+if len(crash_list) > 0:
+ exit_code = 1
+
+ crash_list.sort(key=lambda c: c.stat().st_ctime)
+ print("FAIL: /var/crash is not empty. Crash files sorted by ctime:")
+ print("\n".join([f"- {crash}" for crash in crash_list]))
+else:
+ print("PASS: /var/crash is empty (good)")
+
+print(f"#### /var/crash checked (exit_code: {exit_code}) ####")
+sys.exit(exit_code)
Follow ups
