canonical-ubuntu-qa team mailing list archive

[Skia <mp+461457@xxxxxxxxxxxxxxxxxx>]

Skia has proposed merging ~hyask/autopkgtest-cloud:skia/fix_download-all-results into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/461457
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~hyask/autopkgtest-cloud:skia/fix_download-all-results into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-web/webcontrol/download-all-results b/charms/focal/autopkgtest-web/webcontrol/download-all-results
index 1af7918..e0a11b0 100755
--- a/charms/focal/autopkgtest-web/webcontrol/download-all-results
+++ b/charms/focal/autopkgtest-web/webcontrol/download-all-results
@@ -175,12 +175,11 @@ def fetch_one_result(url):
         exitcode,
     )
     env_vars = []
-    env_spec = {
-        "all-proposed": "all-proposed=1",
-    }
-    for env, spec in env_spec.items():
-        if env in testinfo.keys():
-            env_vars.append(spec)
+    env_spec = ["all-proposed"]
+    for env in env_spec:
+        value = testinfo.get(env)
+        if value is not None:
+            env_vars.append("=".join([env, value]))
 
     while True:
         try: