canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+463351@xxxxxxxxxxxxxxxxxx>]

I only have one inline comment, but other than that, this LGTM as long as it doesn't break bos02 or bos01, which I'm presuming it doesn't. 

I may also not be the best person to review this, but I think it looks good :)

Diff comments:

> diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
> index bb50ada..291715b 100644
> --- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
> +++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
> @@ -61,7 +61,6 @@ write_files:
>           ipv4.address: 10.0.4.1/24
>           ipv4.nat: "true"
>           ipv6.address: none
> -         raw.dnsmasq: dhcp-option=6,91.189.91.130

Why was this dropped?

>         description: ""
>         name: lxdbr0
>         type: bridge


-- 
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/463351
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~hyask/autopkgtest-cloud:skia/lxd-remote-bos03 into autopkgtest-cloud:master.