canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+466379@xxxxxxxxxxxxxxxxxx>]

One inline comment but otherwise LGTM :) 

Diff comments:

> diff --git a/mojo/service-bundle b/mojo/service-bundle
> index 2e90641..c839488 100644
> --- a/mojo/service-bundle
> +++ b/mojo/service-bundle
> @@ -78,16 +78,23 @@ applications:
>              worker-upstream-percentage: 33
>  {%- if stage_name == "production" %}
>              net-name: net_prod-proposed-migration
> -            worker-default-flavor: autopkgtest
> -            worker-big-flavor: autopkgtest-big
> +            worker-flavor-config: |-
> +              default: autopkgtest
> +              big: autopkgtest-big
> +              bos03:
> +                ppc64el:
> +                  default: autopkgtest-ppc64el
> +                  big: autopkgtest-big-ppc64el

LGTM, though, looking ahead to avoid another MP, could you also include s390x here? The flavor will be the same syntax just replacing ppc64el with s390x

>  {%- elif stage_name == "staging" %}
>              net-name: net_stg-proposed-migration-environment
> -            worker-default-flavor: stag-cpu2-ram4-disk20
> -            worker-big-flavor: stag-cpu4-ram16-disk50
> +            worker-flavor-config: |-
> +              default: stag-cpu2-ram4-disk20
> +              big: stag-cpu4-ram16-disk50
>  {%- elif stage_name == "devel" %}
>              net-name: net_instances
> -            worker-default-flavor: cpu2-ram4-disk20
> -            worker-big-flavor: cpu4-ram16-disk50
> +            worker-flavor-config: |-
> +              default: stag-cpu2-ram4-disk20
> +              big: stag-cpu4-ram16-disk50
>  {%- endif %}
>  {%- if stage_name == "production" or stage_name == "staging" %}
>              mirror: http://ftpmaster.internal/ubuntu/


-- 
https://code.launchpad.net/~paride/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/466379
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~paride/autopkgtest-cloud:flexible-flavor-names into autopkgtest-cloud:master.