canonical-ubuntu-qa team mailing list archive

[Paride Legovini <mp+466382@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/create-nova-image-new-release b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/create-nova-image-new-release
> index fbf4da1..a2fb049 100755
> --- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/create-nova-image-new-release
> +++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/create-nova-image-new-release
> @@ -43,7 +43,7 @@ fi
>  
>  if [ "${ARCH}" = amd64 ] && release_ge "${RELEASE}" focal; then
>      ARCHES="[amd64, i386]"
> -    RUNCMD="$(printf "runcmd:\n   - [ dpkg, --add-architecture, i386]\n")"
> +    RUNCMD="$(printf "  - [ dpkg, --add-architecture, i386]\n")"

not to be dropped as part of this MR, but I'm pretty sure this dpkg --add-architecture is not needed, as autopkgtest already does this, at least in the last few iteration of the patch.

>  else
>      ARCHES="default"
>      RUNCMD=


-- 
https://code.launchpad.net/~hyask/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/466382
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~hyask/autopkgtest-cloud:skia/set_passwd_in_testbed into autopkgtest-cloud:master.