canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+467026@xxxxxxxxxxxxxxxxxx>]

The proposal to merge ~andersson123/autopkgtest-cloud:restart-worker-on-charm-update into autopkgtest-cloud:master has been updated.

Commit message changed to:

fix: worker: restart autopkgtest.target when worker code has changed

We've, up until this point, had the finnicky issue of requiring the
autopkgtest admins to manually restart the autopkgtest.target systemd
target upon a charm update.

This is problematic as it's something we could easily miss/forget, and
also requires us to discuss whether a restart of the services is
necessary when we're deciding whether or not to update the charms.

This commit utilises the `any_file_changed` function from
`charms.reactive.helpers`.

The reactive part of the cloud worker charm now checks to see if there's
been any changes to the worker code, and if so, sets the
`autopkgtest.target-restart-needed` flag, restarting autopkgtest.target.

For more details, see:
https://code.launchpad.net/~andersson123/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/467026
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~andersson123/autopkgtest-cloud:restart-worker-on-charm-update into autopkgtest-cloud:master.