canonical-ubuntu-qa team mailing list archive

[Tim Andersson <mp+468345@xxxxxxxxxxxxxxxxxx>]

use yamllint on the file too!

Also todo (not in this MP):
- pre-commit with yamllint
- LPCI with yamllint

Diff comments:

> diff --git a/jobs/hardware-iso-testing/jobs.yaml b/jobs/hardware-iso-testing/jobs.yaml
> new file mode 100644
> index 0000000..53b1d82
> --- /dev/null
> +++ b/jobs/hardware-iso-testing/jobs.yaml
> @@ -0,0 +1,67 @@
> +# vim: sw=4 ts=4 et
> +
> +# QA Jenkins Jobs
> +# Copyright 2016 Canonical Ltd.
> +
> +# This program is free software: you can redistribute it and/or modify it
> +# under the terms of the GNU General Public License version 3, as published
> +# by the Free Software Foundation.
> +
> +# This program is distributed in the hope that it will be useful, but
> +# WITHOUT ANY WARRANTY; without even the implied warranties of
> +# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
> +# PURPOSE.  See the GNU General Public License for more details.
> +
> +# You should have received a copy of the GNU General Public License along
> +# with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +- project:
> +    name: 'hardware-iso-testing'
> +    variant:
> +        - 'desktop'
> +    release:
> +        - 'noble'
> +    test-case:
> +        - 'end-to-end-test'
> +    client-machine:
> +        - 'client_1' # to be read from /var/lib/jenkins/hardware-testing-clients.json

talk to the zapper guys about this - can IP's be in a public repo?

Also, define using jenkins secrets

Also, look into API key for C3?

> +    node: 'venonat'
> +    jobs:
> +        - '{release}-{variant}-{test-case}-installer-test-{client-machine}'

rename to 'hardware-{release}-{variant}-installer-{test-case}-{client-machine}'

> +
> +# builder stanzas describe reusable build steps
> +- builder:
> +    name: run-hardware-installer-test
> +    builders:
> +        - shell: |
> +            cd hardware-installer-testing/
> +            git checkout installer-test-suite
> +            pip3 install rpyc==5.3.1

change to apt not pip - or do a python venv

> +            machine_ip=$(jq --raw-output '.{client-machine}' /var/lib/jenkins/hardware-testing-clients.json)

to be amended in line with previous comment

> +            python3 ./scripts/call_job.py --job-config test-definitions/{release}/{test-case}.json --client-ip $machine_ip

nit: add quotes for machine_ip

> +
> +# job templates
> +- job-template:
> +    name: '{release}-{variant}-{test-case}-installer-test-{client-machine}'

change name in line with previous comment

> +    description: |
> +        Runs a test defined in gh:/canonical/hardware-installer-testing
> +    node: 'venonat'
> +    parameters:

this parameter isn't needed as we're not cloning qa-jenkins-jobs - can rename to hardware-installer-testing branch instead?

> +      - string:
> +          name: QA_JENKINS_JOBS_BRANCH
> +          default: lp:qa-jenkins-jobs
> +          description: "Launchpad branch of qa-jenkins-jobs from which to pick the scripts from."
> +    wrappers:
> +      - timeout:
> +          timeout: 3600
> +          fail: true
> +      - timestamps
> +    builders:

need to store the artifacts as well!

> +        - clear-artifacts:
> +        - git-shallow-clone:
> +            project-url: 'https://github.com/canonical/hardware-installer-testing.git'
> +            project-name: 'hardware-installer-testing'
> +        - run-hardware-installer-test:
> +            release: '{release}'
> +            test-case: '{test-case}'
> +            client-machine: '{client-machine}'


-- 
https://code.launchpad.net/~andersson123/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/468345
Your team Canonical Platform QA Team is requested to review the proposed merge of ~andersson123/qa-jenkins-jobs:add-zapper-jobs into qa-jenkins-jobs:master.