canonical-ubuntu-qa team mailing list archive

[Brian Murray <mp+469240@xxxxxxxxxxxxxxxxxx>]

Brian Murray has proposed merging autopkgtest-cloud:space-triggers into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/469240

I was hitting some exceptions today and noticed the triggers weren't space separated.
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of autopkgtest-cloud:space-triggers into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-web/webcontrol/helpers/exceptions.py b/charms/focal/autopkgtest-web/webcontrol/helpers/exceptions.py
index 0147b32..cdfa03d 100644
--- a/charms/focal/autopkgtest-web/webcontrol/helpers/exceptions.py
+++ b/charms/focal/autopkgtest-web/webcontrol/helpers/exceptions.py
@@ -28,7 +28,7 @@ class RequestInQueue(WebControlException):
     def __init__(self, release, package, arch, triggers):
         super().__init__(
             "Test already queued:\nrelease: %s\npkg: %s\narch: %s\ntriggers: %s"
-            % (release, package, arch, ",".join(triggers)),
+            % (release, package, arch, ", ".join(triggers)),
             403,
         )
 
@@ -37,7 +37,7 @@ class RequestRunning(WebControlException):
     def __init__(self, release, package, arch, triggers):
         super().__init__(
             "Test already running:\nrelease: %s\npkg: %s\narch: %s\ntriggers: %s"
-            % (release, package, arch, ",".join(triggers)),
+            % (release, package, arch, ", ".join(triggers)),
             403,
         )
 
@@ -98,7 +98,7 @@ class InvalidArgs(WebControlException):
             (
                 (
                     "You have passed invalid args: %s\nPlease see an example url below:\n%s"
-                    % (",".join(parameters.keys()), EXAMPLE_URL)
+                    % (", ".join(parameters.keys()), EXAMPLE_URL)
                 )
             ),
             400,