canonical-ubuntu-qa team mailing list archive

[Ural Tunaboyu <mp+471372@xxxxxxxxxxxxxxxxxx>]

> Okay, great!
> 
> Now, just to be on the safe side, I recommend running:
> ./scripts/deploy-jobs.sh test
> 
> before and after your linting changes, and then checking the diff of the
> output provided by jenkins job builder. I don't expect there to be changes,
> but I think we should be on the safe side :) After that I'm happy to review

It's a nonzero diff but it still looks fairly trivial:

$ diff linted-output unlinted-output 
226c226
< else
---
> else    
228c228
< fi
---
> fi 

Disappears when I ignore changes in amount of white space:
$ diff linted-output unlinted-output && echo $?
0

-- 
https://code.launchpad.net/~canonical-platform-qa/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/471372
Your team Canonical Platform QA Team is requested to review the proposed merge of qa-jenkins-jobs:pre-commit-hooks into qa-jenkins-jobs:master.