canonical-ubuntu-qa team mailing list archive

[Adrien Nader <mp+482540@xxxxxxxxxxxxxxxxxx>]

There's a potentiel performance improvement because this avoids querying the DB separately for each test as that is now part of a JOIN.

I've also noticed that there was probably an error in get_results() when the DB is empty: one field was missing but that was difficult to spot without the names. I've added the field names and that gives "url=False," which is likely not what we want but I'm not sure where exactly the shift should begin. Let me know or feel free to fix it directly.

I checked the recent page, user page, the filtering options and the JSON output. Everything looks good. I've had to touch templates/browse-recent.html too but couldn't test it (not without a better test setup it seems) but it's the same code as in templates/browse-user.html.
-- 
https://code.launchpad.net/~adrien/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/482540
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~adrien/autopkgtest-cloud:browse-recent-filters-and-json into autopkgtest-cloud:master.