canonical-ubuntu-qa team mailing list archive

[Adrien Nader <mp+482608@xxxxxxxxxxxxxxxxxx>]

Adrien Nader has proposed merging ~adrien/autopkgtest-cloud:browse-recent-broken-package-result-page into autopkgtest-cloud:master.

Requested reviews:
  Canonical's Ubuntu QA (canonical-ubuntu-qa)

For more details, see:
https://code.launchpad.net/~adrien/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/482608
-- 
Your team Canonical's Ubuntu QA is requested to review the proposed merge of ~adrien/autopkgtest-cloud:browse-recent-broken-package-result-page into autopkgtest-cloud:master.

diff --git a/charms/focal/autopkgtest-web/webcontrol/browse.cgi b/charms/focal/autopkgtest-web/webcontrol/browse.cgi
index cf967d6..4fa21bc 100755
--- a/charms/focal/autopkgtest-web/webcontrol/browse.cgi
+++ b/charms/focal/autopkgtest-web/webcontrol/browse.cgi
@@ -734,18 +734,18 @@ def package_release_arch(package, release, arch, _=None):
             and "all-proposed=1" in additional_params
         )
         results.append(
-            (
-                version,
-                triggers,
-                additional_params,
-                human_date(row[0]),
-                human_sec(int(row[3])),
-                requester,
-                code,
-                url,
-                show_retry,
-                all_proposed,
-                row[7],
+            dict(
+                version=version,
+                triggers=triggers,
+                additional_params=additional_params,
+                human_date=human_date(row[0]),
+                human_sec=human_sec(int(row[3])),
+                requester=requester,
+                code=code,
+                url=url,
+                show_retry=show_retry,
+                all_proposed=all_proposed,
+                uuid=row[7],
             )
         )
 
@@ -756,18 +756,18 @@ def package_release_arch(package, release, arch, _=None):
             if job:
                 results.insert(
                     0,
-                    (
-                        "N/A",
-                        job[0].get("triggers"),
-                        "N/A",
-                        human_date(job[0].get("submit-time")),
-                        human_sec(int(job[1])),
-                        job[0].get("requester", "-"),
-                        "running",
-                        "",
-                        False,
-                        "",
-                        job[0].get("uuid", "-"),
+                    dict(
+                        version="N/A",
+                        triggers=job[0].get("triggers"),
+                        additional_params="N/A",
+                        human_date=human_date(job[0].get("submit-time")),
+                        human_sec=human_sec(int(job[1])),
+                        requester=job[0].get("requester", "-"),
+                        code="running",
+                        url="",
+                        show_retry=False,
+                        all_proposed="",
+                        uuid=job[0].get("uuid", "-"),
                     ),
                 )
     except Exception:
@@ -775,18 +775,18 @@ def package_release_arch(package, release, arch, _=None):
         # Let's signal the error in the page, but still display other results
         results.insert(
             0,
-            (
-                "Unknown running list",
-                "There are errors in running.json",
-                "Please contact QA team",
-                "",
-                "",
-                "",
-                "",
-                "",
-                False,
-                "",
-                "",
+            dict(
+                version="Unknown running list",
+                triggers="There are errors in running.json",
+                additional_params="Please contact QA team",
+                human_date="",
+                human_sec="",
+                requester="",
+                code="",
+                url="",
+                show_retry=False,
+                all_proposed="",
+                uuid="",
             ),
         )