canonical-ubuntu-qa team mailing list archive

[Paride Legovini <mp+482575@xxxxxxxxxxxxxxxxxx>]

Replying to now-lost inline questions.

>> Nit (cosmetic): in general all this yaml is a bit inconsistent about
>> what is quoted and what is not quotes.
>
> I'm not sure where you mean - can you be a bit more specific?
> I've tried to follow the quoting wherever it's denoted in the
> jenkins job builder definition wiki

For example, these are all strings, some are quoted, some are not:

name: HIT_BRANCH
default: 'main'
polling-node: 'iso-testing'
credential-id: GH_PAT

bug again, this is basically cosmetic. OTOH this *may* be an issue:

allow-empty: 'true'

as that's the "true" string, and not the boolean true. But maybe it just works.


-- 
https://code.launchpad.net/~canonical-platform-qa/qa-jenkins-jobs/+git/qa-jenkins-jobs/+merge/482575
Your team Canonical Platform QA Team is requested to review the proposed merge of qa-jenkins-jobs:rf-vm-iso-tests into qa-jenkins-jobs:master.