← Back to team overview

canonical-ubuntu-qa team mailing list archive

[Bug 2110562] Re: plucky: ubuntu_lttng_smoke_test conflicting types for ‘trace_balance_dirty_pages’

 

The debdiff in attach allows to build lttng-modules-dkms on Plucky
6.14.0-17-generic.

The new dkms has been tested both on 6.14.0-15-generic (to spot possible regressions) and on 6.14.0-17-generic.
The package builds correctly:

$ dkms status
lttng-modules/2.13.17, 6.14.0-15-generic, x86_64: installed
lttng-modules/2.13.17, 6.14.0-17-generic, x86_64: installed

The module has been also loaded on both kernels without any error
showing in the message buffer.

** Patch added: "lttng-modules-plucky-fix.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/lttng-modules/+bug/2110562/+attachment/5877317/+files/lttng-modules-plucky-fix.debdiff

** Description changed:

  plucky 6.14.0-17-17 ubuntu_lttng_smoke_test:lttng-smoke-test has been
  failing due to compilation error. Probably test code needs to be
  updated.
  
  [ Impact ]
  
- lttng-modules does not compile from source in Plucky 6.14.0-17-genereic:
+ lttng-modules does not compile from source in Plucky 6.14.0-17-generic:
  
  834  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-rcu.o
  835  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-sunrpc.o
  836  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-workqueue.o
  837  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-writeback.o
  838  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-kprobes.o
  839  23:05:51 DEBUG| [stdout] In file included from src/probes/../../include/lttng/define_trace.h:87,
  840  23:05:51 DEBUG| [stdout] from src/probes/../../include/instrumentation/events/writeback.h:815,
  841  23:05:51 DEBUG| [stdout] from src/probes/lttng-probe-writeback.c:38:
  842  23:05:51 DEBUG| [stdout] src/probes/../../include/lttng/tracepoint-event-impl.h:133:6: error: conflicting types for ‘trace_balance_dirty_pages’; have ‘void(struct bdi_writeback *, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long int, long unsigned int)’
  843  23:05:51 DEBUG| [stdout] 133 | void trace_##_name(_proto);
  844  23:05:51 DEBUG| [stdout] | ^~~~~~
  845  23:05:51 DEBUG| [stdout] src/probes/../../include/lttng/tracepoint-event-impl.h:45:9: note: in expansion of macro ‘LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP’
  846  23:05:51 DEBUG| [stdout] 45 | LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(map, name, map, PARAMS(proto), PARAMS(args))
  847  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  848  23:05:51 DEBUG| [stdout] src/probes/../../include/instrumentation/events/writeback.h:618:1: note: in expansion of macro ‘LTTNG_TRACEPOINT_EVENT_MAP’
  849  23:05:51 DEBUG| [stdout] 618 | LTTNG_TRACEPOINT_EVENT_MAP(balance_dirty_pages,
  850  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~~~~~~~~~~~~~~
  851  23:05:51 DEBUG| [stdout] In file included from /usr/src/linux-headers-6.14.0-17-generic/include/trace/events/writeback.h:8,
  852  23:05:51 DEBUG| [stdout] from src/probes/lttng-probe-writeback.c:20:
  853  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/linux/tracepoint.h:278:28: note: previous definition of ‘trace_balance_dirty_pages’ with type ‘void(struct bdi_writeback *, struct dirty_throttle_control *, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long int, long unsigned int)’
  854  23:05:51 DEBUG| [stdout] 278 | static inline void trace_##name(proto) \
  855  23:05:51 DEBUG| [stdout] | ^~~~~~
  856  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/linux/tracepoint.h:467:9: note: in expansion of macro ‘__DECLARE_TRACE’
  857  23:05:51 DEBUG| [stdout] 467 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
  858  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~~~
  859  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/linux/tracepoint.h:605:9: note: in expansion of macro ‘DECLARE_TRACE’
  860  23:05:51 DEBUG| [stdout] 605 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  861  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~
  862  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/trace/events/writeback.h:629:1: note: in expansion of macro ‘TRACE_EVENT’
  863  23:05:51 DEBUG| [stdout] 629 | TRACE_EVENT(balance_dirty_pages,
  864  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~
  865  23:05:51 DEBUG| [stdout] make[5]: *** [/usr/src/linux-headers-6.14.0-17-generic/scripts/Makefile.build:207: src/probes/lttng-probe-writeback.o] Error 1
  866  23:05:51 DEBUG| [stdout] make[5]: *** Waiting for unfinished jobs....
  867  23:05:51 DEBUG| [stdout] make[4]: *** [/usr/src/linux-headers-6.14.0-17-generic/scripts/Makefile.build:465: src/probes] Error 2
  868  23:05:51 DEBUG| [stdout] make[3]: *** [/usr/src/linux-headers-6.14.0-17-generic/scripts/Makefile.build:465: src] Error 2
  869  23:05:51 DEBUG| [stdout] make[2]: *** [/usr/src/linux-headers-6.14.0-17-generic/Makefile:2001: .] Error 2
  870  23:05:51 DEBUG| [stdout] make[1]: *** [/usr/src/linux-headers-6.14.0-17-generic/Makefile:251: __sub-make] Error 2
  871  23:05:51 DEBUG| [stdout] make[1]: Leaving directory '/var/lib/dkms/lttng-modules/2.13.17/build'
  872  23:05:51 DEBUG| [stdout] make: *** [Makefile:251: __sub-make] Error 2
  873  23:05:51 DEBUG| [stdout] make: Leaving directory '/usr/src/linux-headers-6.14.0-17-generic'
  
  [ Test Case ]
  
  Install the latest kernel from the proposed pocket on Plucky and .
  Install lttng-modules:
  $ sudo apt install lttng-modules-dkms
  Load the module:
  $ sudo modprobe lttng-test
  
  The same procedure must be repeated on Plucky previous kernels too avoid
  regressions.
  
  [ Fix ]
  
  Patch the DKMS to properly support the new linux ABI in Linux 6.14.2
  
  [ Regression potential ]
  
  We may experience regressions in systems that are using the lttng
  debugging tools in Plucky.

-- 
You received this bug notification because you are a member of Canonical
Platform QA Team, which is subscribed to ubuntu-kernel-tests.
https://bugs.launchpad.net/bugs/2110562

Title:
  plucky: ubuntu_lttng_smoke_test conflicting types for
  ‘trace_balance_dirty_pages’

Status in ubuntu-kernel-tests:
  In Progress
Status in lttng-modules package in Ubuntu:
  Invalid
Status in lttng-modules source package in Plucky:
  In Progress

Bug description:
  plucky 6.14.0-17-17 ubuntu_lttng_smoke_test:lttng-smoke-test has been
  failing due to compilation error. Probably test code needs to be
  updated.

  [ Impact ]

  lttng-modules does not compile from source in Plucky
  6.14.0-17-generic:

  834  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-rcu.o
  835  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-sunrpc.o
  836  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-workqueue.o
  837  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-probe-writeback.o
  838  23:05:51 DEBUG| [stdout] CC [M] src/probes/lttng-kprobes.o
  839  23:05:51 DEBUG| [stdout] In file included from src/probes/../../include/lttng/define_trace.h:87,
  840  23:05:51 DEBUG| [stdout] from src/probes/../../include/instrumentation/events/writeback.h:815,
  841  23:05:51 DEBUG| [stdout] from src/probes/lttng-probe-writeback.c:38:
  842  23:05:51 DEBUG| [stdout] src/probes/../../include/lttng/tracepoint-event-impl.h:133:6: error: conflicting types for ‘trace_balance_dirty_pages’; have ‘void(struct bdi_writeback *, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long int, long unsigned int)’
  843  23:05:51 DEBUG| [stdout] 133 | void trace_##_name(_proto);
  844  23:05:51 DEBUG| [stdout] | ^~~~~~
  845  23:05:51 DEBUG| [stdout] src/probes/../../include/lttng/tracepoint-event-impl.h:45:9: note: in expansion of macro ‘LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP’
  846  23:05:51 DEBUG| [stdout] 45 | LTTNG_TRACEPOINT_EVENT_INSTANCE_MAP(map, name, map, PARAMS(proto), PARAMS(args))
  847  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  848  23:05:51 DEBUG| [stdout] src/probes/../../include/instrumentation/events/writeback.h:618:1: note: in expansion of macro ‘LTTNG_TRACEPOINT_EVENT_MAP’
  849  23:05:51 DEBUG| [stdout] 618 | LTTNG_TRACEPOINT_EVENT_MAP(balance_dirty_pages,
  850  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~~~~~~~~~~~~~~
  851  23:05:51 DEBUG| [stdout] In file included from /usr/src/linux-headers-6.14.0-17-generic/include/trace/events/writeback.h:8,
  852  23:05:51 DEBUG| [stdout] from src/probes/lttng-probe-writeback.c:20:
  853  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/linux/tracepoint.h:278:28: note: previous definition of ‘trace_balance_dirty_pages’ with type ‘void(struct bdi_writeback *, struct dirty_throttle_control *, long unsigned int, long unsigned int, long unsigned int, long unsigned int, long int, long unsigned int)’
  854  23:05:51 DEBUG| [stdout] 278 | static inline void trace_##name(proto) \
  855  23:05:51 DEBUG| [stdout] | ^~~~~~
  856  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/linux/tracepoint.h:467:9: note: in expansion of macro ‘__DECLARE_TRACE’
  857  23:05:51 DEBUG| [stdout] 467 | __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), \
  858  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~~~
  859  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/linux/tracepoint.h:605:9: note: in expansion of macro ‘DECLARE_TRACE’
  860  23:05:51 DEBUG| [stdout] 605 | DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  861  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~~~
  862  23:05:51 DEBUG| [stdout] /usr/src/linux-headers-6.14.0-17-generic/include/trace/events/writeback.h:629:1: note: in expansion of macro ‘TRACE_EVENT’
  863  23:05:51 DEBUG| [stdout] 629 | TRACE_EVENT(balance_dirty_pages,
  864  23:05:51 DEBUG| [stdout] | ^~~~~~~~~~~
  865  23:05:51 DEBUG| [stdout] make[5]: *** [/usr/src/linux-headers-6.14.0-17-generic/scripts/Makefile.build:207: src/probes/lttng-probe-writeback.o] Error 1
  866  23:05:51 DEBUG| [stdout] make[5]: *** Waiting for unfinished jobs....
  867  23:05:51 DEBUG| [stdout] make[4]: *** [/usr/src/linux-headers-6.14.0-17-generic/scripts/Makefile.build:465: src/probes] Error 2
  868  23:05:51 DEBUG| [stdout] make[3]: *** [/usr/src/linux-headers-6.14.0-17-generic/scripts/Makefile.build:465: src] Error 2
  869  23:05:51 DEBUG| [stdout] make[2]: *** [/usr/src/linux-headers-6.14.0-17-generic/Makefile:2001: .] Error 2
  870  23:05:51 DEBUG| [stdout] make[1]: *** [/usr/src/linux-headers-6.14.0-17-generic/Makefile:251: __sub-make] Error 2
  871  23:05:51 DEBUG| [stdout] make[1]: Leaving directory '/var/lib/dkms/lttng-modules/2.13.17/build'
  872  23:05:51 DEBUG| [stdout] make: *** [Makefile:251: __sub-make] Error 2
  873  23:05:51 DEBUG| [stdout] make: Leaving directory '/usr/src/linux-headers-6.14.0-17-generic'

  [ Test Case ]

  Install the latest kernel from the proposed pocket on Plucky and .
  Install lttng-modules:
  $ sudo apt install lttng-modules-dkms
  Load the module:
  $ sudo modprobe lttng-test

  The same procedure must be repeated on Plucky previous kernels too
  avoid regressions.

  [ Fix ]

  Patch the DKMS to properly support the new linux ABI in Linux 6.14.2

  [ Regression potential ]

  We may experience regressions in systems that are using the lttng
  debugging tools in Plucky.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2110562/+subscriptions



References