canonical-x team mailing list archive

[Bryce Harrington <bryce@xxxxxxxxxxxxx>]

Urk, missed several more patches (see end of email)


On Thu, Feb 21, 2013 at 07:59:44AM -0800, Bryce Harrington wrote:
> On Wed, Feb 20, 2013 at 10:01:17AM -0800, Bryce Harrington wrote:
> > https://build.opensuse.org/package/view_file?expand=1&file=N_0001-Check-harder-for-primary-PCI-device.patch&package=xorg-x11-server&project=openSUSE%3AFactory
> > 
> >   This looks like it could be useful if merged with our patch
> >   188_default_primary_to_first_busid.patch.  Low priority, but I'll take
> >   the action to work on this one.
> > 
> > 
> > https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Don-t-let-VNC-access-the-framebuffer-directly-an.patch&package=xorg-x11-server&project=openSUSE%3AFactory
> > https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Add-proto.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> > https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Add-support-for-VNC.patch&package=xorg-x11-server&project=openSUSE%3AFactory
> > 
> >   Set of VNC patches, to fix build issues, etc.  Don't know if we care
> >   that much about about VNC but the patches look straightforward.
> 
> Do you know what these patches are for?  I'm guessing we can ignore them
> since vnc is really its own package.
> 
> > 
> > https://build.opensuse.org/package/view_file?expand=1&file=N_vidmode-sig11.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> > 
> >   Simple null ptr fix.  Apparently fixes bnc #439354, which
> >   unfortunately is private, but an old bug so dunno if it's at all still
> >   relevant.  Guessing not, else we'd have fixed it just as easily...
> 
> Assuming this one is skippable for now, unless you think we should pull
> it.
> 
> > 
> > https://build.opensuse.org/package/view_file?expand=1&file=N_randr1_1-sig11.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> > 
> >   Null ptr check to fix
> >   https://bugzilla.novell.com/show_bug.cgi?id=223459
> > 
> >   At least on -intel, I can't reproduce; it gracefully refuses to change
> >   the screen resolution once I switch back.
> 
> Since I can't reproduce I'm guessing this isn't worth including, but
> it's a simple enough fix.  What do you think?
> 
> > 
> [deleted]
> > 
> > 
> > More to come...
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_0001-Prevent-XSync-Alarms-from-senslessly-calling-CheckTr.patch&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Seems to be a 100% X CPU bug that used to hit kde.  Don't know if it
>   can be reproduced with !kde, or current kde.  Patch probably ought to
>   go upstream.
> 
>     https://bugs.kde.org/show_bug.cgi?id=231628 
> 
>   Guessing we can skip it; anyone disagree?
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_0001-Xinput-Catch-missing-configlayout-when-deleting-dev.patch&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Nullptr check to prevent crashes in DeleteInputDeviceRequest.  We've
>   had crashes involving this routine in the past, although I don't know
>   they were derefs of idev.  Still, it's crashy code and more ptr checks
>   couldn't hurt...?
> 
>   Thinking we could pull this one in, in hopes it improves matters.
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_bug-197858_dpms.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Fix for https://bugzilla.novell.com/show_bug.cgi?id=197858, where X
>   wakes on any ACPI event.  If we disable ACPI (as per the fedora
>   patch), this is irrelevant.
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_bug534768-prefer_local_symbols.patch&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Fix for https://bugzilla.novell.com/show_bug.cgi?id=534768.  This
>   fixes resolution of symbols between radeon and radeonhd.  Since we
>   don't ship the latter, guessing this patch isn't too important for us,
>   however it does solve a general problem.  Would like to see this go
>   upstream, but for us guess we can skip it?
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_confine_to_shape.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   This seems to be a pretty old patch that has fallen through the cracks
>   all these years.  It's unclear to me what the problem is that this
>   fixes (bnc #62146 appears private) but seems to have to do with cursor
>   movement when placed on shapes.
> 
>   https://bugs.freedesktop.org/show_bug.cgi?id=3370
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_dpms_screensaver.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   I couldn't find the bug report that led to this patch, but it seems to
>   update the screensaver in certain cases.  Possibly this could solve
>   some of the long standing screen blanking bugs (or cause more!)
> 
>   It appears this might have caused a 100% CPU regression - see comment
>   #7 on https://bugzilla.novell.com/show_bug.cgi?id=473302.  So if we
>   pull this, we might want the patch on that bug as well.
> 
>   Don't think we should pull this one; would rather have it go upstream
>   and us pull from there.  So maybe we could bump it up there ourselves?
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_edid_data_sanity_check.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Didn't find a bug report on this one.  Looks like it works around bad
>   EDID by detecting aspect ratios larger than 2.0 or smaller than 0.5,
>   when there is defined height and width.  I don't know how often we
>   still run into such issues but might be worth further study.
> 
>   Guessing this would be worth pulling in, or sending upstream at least.
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_fix-dpi-values.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Looks like it tries to improve DPI calculations by using HDisplay from
>   the mode, when available.
> 
>   But IIRC we pretty much don't rely on the X dpi calculations at all,
>   and just set it to 60 dpi in gnome, right?  If so, this may be
>   irrelevant.
> 
>   Guessing we can ignore this one.  They should upstream it though.
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_p_default-module-path.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Looks distro-specific for finding module updates or something.
>   Skip.
> 
> 
> https://build.opensuse.org/package/view_file?expand=1&file=N_p_xnest-ignore-getimage-errors.diff&package=xorg-x11-server&project=openSUSE%3AFactory
> 
>   Quells "BadMatch" error in xnest.  I don't know if we still care about
>   xnest, and didn't spot bug reports about this in launchpad.  However,
>   there's one in debian that seems to match:
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=309226
> 
>   There's some disagreement as to whether it's still reproducible or
>   not, however the patch looks pretty straightforward.
> 
>   Guessing if we care about xnest, may want to pull this patch.
 
https://build.opensuse.org/package/view_file?expand=1&file=u_init_framebuffer_base.patch&package=xorg-x11-server&project=openSUSE%3AFactory

  Looks important but no idea what it fixes.   Could not find a bug
  reference for it.

  Guessing if this were a problem for us, we'd have hit it and noticed?

https://build.opensuse.org/package/view_file?expand=1&file=u_vgaHW-no-legacy.patch&package=xorg-x11-server&project=openSUSE%3AFactory

  This looks interesting, like it makes X skip checking the VGA port on
  hardware that never has VGA.  However, do we care about X on arm?  And
  I seem to recall we had explored other fixes in the past?

https://build.opensuse.org/package/view_file?expand=1&file=N_sync-fix.patch&package=xorg-x11-server&project=openSUSE%3AFactory

  Not quite sure what this fixes?  Something to do with adjusting how he
  xsync module works; do we use that for anything?  If not, guessing we
  can skip this.


https://build.opensuse.org/package/view_file?expand=1&file=n_Xvnc-pthread.diff&package=xorg-x11-server&project=openSUSE%3AFactory
https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Readd-timeout-when-vnc-viewer-connection-breaks.patch&package=xorg-x11-server&project=openSUSE%3AFactory
https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Fix-crash-when-no-depth-translation-is-required.patch&package=xorg-x11-server&project=openSUSE%3AFactory
https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Fix-crash-due-to-unset-input-device-names.patch&package=xorg-x11-server&project=openSUSE%3AFactory
https://build.opensuse.org/package/view_file?expand=1&file=n_VNC-Enable-use-of-all-keyboard-layouts-independent-o.patch&package=xorg-x11-server&project=openSUSE%3AFactory

  Bunch more VNC patches.  Again, if we care about VNC, these look
  worthwhile, otherwise skip?

 
 
> The remaining patches all we either have, or are upstream, or were
> clearly inapplicable to ubuntu.
> 
> Feeedback on all the above (including the redhat patches from earlier)
> is welcomed.  Timo - let me know if you will cherrypick these patches,
> otherwise I can take care of it in a week or two once I'm back home.
>