cf-charmers team mailing list archive

Thread
Date

Re: update helpers (issue 88870043)

To: Alex Lomov <lomov.as@xxxxxxxxx>
From: Benjamin Saller <benjamin.saller@xxxxxxxxxxxxx>
Date: Thu, 17 Apr 2014 15:21:18 -0000
In-reply-to: <20140409192821.2712.90651.launchpad@ackee.canonical.com>
Reply-to: mp+215018@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

LGTM, thanks!


lbox submit

should merge this for you


https://codereview.appspot.com/88870043/diff/1/charmhelpers/contrib/cloudfoundry/upstart_helper.py
File charmhelpers/contrib/cloudfoundry/upstart_helper.py (right):

https://codereview.appspot.com/88870043/diff/1/charmhelpers/contrib/cloudfoundry/upstart_helper.py#newcode10
charmhelpers/contrib/cloudfoundry/upstart_helper.py:10: dirname =
os.path.join(hookenv.charm_dir(), 'files/upstart')
Thanks for fixing this. Much better not to run that code on import

https://codereview.appspot.com/88870043/

-- 
https://code.launchpad.net/~lomov-as/charm-helpers/cloud-foundry/+merge/215018
Your team Cloud Foundry Charmers is subscribed to branch lp:~cf-charmers/charm-helpers/cloud-foundry.