cf-charmers team mailing list archive

[Alexander Lomov <lomov.as@xxxxxxxxx>]

Hi, all.

Cory, we agreed to use Merge Proposals to update trunk. I have used lbox
[1] to merge changes. You can ask Ben about details.

Ben, could you review changes in 32nd revision in cf-dea charm [2]? I'm not
sure that it is good idea to move upstart job files to template folder
because :

- first of all it brings mess to templates folder (after this refactor
there is no any structure there and config file are on the same level with
upstart jobs)
- upstart jobs files are not templates (and I think it's better to leave
them as they are in current version of charms)
- using `services.register` for upstart jobs against `install_upstart_jobs`
increases amount of code
- using files that are not templates in `services.register` declaration is
not idea behind services module of charm helpers (we always used installed
file that are not templates within install hook [3, 4])
- upstart jobs will be rerendered every time we start service; it's not so
bad, but I prefer to avoid unnecessary actions.


Thank you,
Alex L.


References:
[1] http://blog.labix.org/2011/11/17/launchpad-rietveld-happycodereviews
[2]
http://bazaar.launchpad.net/~cf-charmers/charms/trusty/cf-dea/trunk/revision/32

On 14 May 2014 22:20, Cory Johns <cory.johns@xxxxxxxxxxxxx> wrote:

> Alex,
>
> My apologies.  That was supposed to go to a feature branch, but was
> applied to a lightweight checkout by mistake and so automatically pushed
> itself.  I was told, though, that it wouldn't be a problem, since the
> bundle was tagged to specific revisions of the charms, but then the tagging
> was removed in trunk after that, which caused it to become an issue.
>
> So, I've pushed a revert commit to fix cf-dea/trunk, and the feature
> branches are up for review separately and can be all merged together when
> ready, as they were intended.
>
>
> On Wed, May 14, 2014 at 12:22 PM, Prismakov Alexander <
> alexander.prismakov@xxxxxxxxxxx> wrote:
>
>>  Hi Cory,
>>
>>  After 32 revision of cf-dea we have broken upstart jobs (e.g. cf-warden
>> actually contains dir-server job)
>> Please take look here -
>> http://bazaar.launchpad.net/~cf-charmers/charms/trusty/cf-dea/trunk/view/head:/hooks/hooks.py#L48<http://bazaar.launchpad.net/~cf-charmers/charms/trusty/cf-dea/trunk/view/head:/hooks/hooks.py#L52>
>>
>>  Guys, please be more careful with pushing code to trunk. Code need to
>> be checked by integration tests (at least manually)
>> before applying to trunk.
>>
>>  Now we need to redeploy CF, reconfigure and rerun MySQL broker etc.
>>
>>  -Alex Prismakov
>>
>>
>>
>>
>
> --
> Mailing list: https://launchpad.net/~cf-charmers
> Post to     : cf-charmers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~cf-charmers
> More help   : https://help.launchpad.net/ListHelp
>
>